* [patch] PS3: Fix gelic net module dependency
@ 2008-04-09 21:01 Geoff Levand
2008-04-09 21:42 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Geoff Levand @ 2008-04-09 21:01 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev@ozlabs.org, Jeff Garzik
The PS3 gelic network driver depends on the wake-on-lan support
provided by the PS3 sys manager driver. Add that dependency
to the GELIC_NET Kconfig option.
Prevents these build errors:
ps3_gelic_net.c:1277: undefined reference to `.ps3_sys_manager_get_wol'
ps3_gelic_net.c:1337: undefined reference to `.ps3_sys_manager_set_wol'
CC: Masakazu Mokuno <mokuno@sm.sony.co.jp>
CC: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Hi Paul,
This fixes an error introduced in my 2.6.26 WOL patches now
queued in your powerpc tree. Please apply.
-Geoff
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2358,6 +2358,7 @@ config TSI108_ETH
config GELIC_NET
tristate "PS3 Gigabit Ethernet driver"
depends on PPC_PS3
+ select PS3_SYS_MANAGER
help
This driver supports the network device on the PS3 game
console. This driver has built-in support for Ethernet.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] PS3: Fix gelic net module dependency
2008-04-09 21:01 [patch] PS3: Fix gelic net module dependency Geoff Levand
@ 2008-04-09 21:42 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-09 21:42 UTC (permalink / raw)
To: Geoff Levand; +Cc: linuxppc-dev@ozlabs.org, Paul Mackerras
Geoff Levand wrote:
> The PS3 gelic network driver depends on the wake-on-lan support
> provided by the PS3 sys manager driver. Add that dependency
> to the GELIC_NET Kconfig option.
>
> Prevents these build errors:
>
> ps3_gelic_net.c:1277: undefined reference to `.ps3_sys_manager_get_wol'
> ps3_gelic_net.c:1337: undefined reference to `.ps3_sys_manager_set_wol'
>
> CC: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> CC: Jeff Garzik <jgarzik@pobox.com>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> Hi Paul,
>
> This fixes an error introduced in my 2.6.26 WOL patches now
> queued in your powerpc tree. Please apply.
>
> -Geoff
>
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2358,6 +2358,7 @@ config TSI108_ETH
> config GELIC_NET
> tristate "PS3 Gigabit Ethernet driver"
> depends on PPC_PS3
> + select PS3_SYS_MANAGER
> help
> This driver supports the network device on the PS3 game
> console. This driver has built-in support for Ethernet.
looks sane to me, but I do not have enough knowledge to ACK. Thanks for
the CC :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-09 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-09 21:01 [patch] PS3: Fix gelic net module dependency Geoff Levand
2008-04-09 21:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).