linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [patch] PS3: Fix gelic net module dependency
Date: Wed, 09 Apr 2008 17:42:18 -0400	[thread overview]
Message-ID: <47FD383A.7040604@pobox.com> (raw)
In-Reply-To: <47FD2EC1.8030600@am.sony.com>

Geoff Levand wrote:
> The PS3 gelic network driver depends on the wake-on-lan support
> provided by the PS3 sys manager driver.  Add that dependency
> to the GELIC_NET Kconfig option.
> 
> Prevents these build errors:
> 
>   ps3_gelic_net.c:1277: undefined reference to `.ps3_sys_manager_get_wol'
>   ps3_gelic_net.c:1337: undefined reference to `.ps3_sys_manager_set_wol'
> 
> CC: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> CC: Jeff Garzik <jgarzik@pobox.com>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
> Hi Paul,
> 
> This fixes an error introduced in my 2.6.26 WOL patches now
> queued in your powerpc tree.  Please apply.
> 
> -Geoff
> 
>  drivers/net/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2358,6 +2358,7 @@ config TSI108_ETH
>  config GELIC_NET
>  	tristate "PS3 Gigabit Ethernet driver"
>  	depends on PPC_PS3
> +	select PS3_SYS_MANAGER
>  	help
>  	  This driver supports the network device on the PS3 game
>  	  console.  This driver has built-in support for Ethernet.

looks sane to me, but I do not have enough knowledge to ACK.  Thanks for 
the CC :)

      reply	other threads:[~2008-04-09 21:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-09 21:01 [patch] PS3: Fix gelic net module dependency Geoff Levand
2008-04-09 21:42 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FD383A.7040604@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=geoffrey.levand@am.sony.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).