From: Tejun Heo <htejun@gmail.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, gregkh@suse.de,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 6/13] devres: implement managed iomap interface
Date: Fri, 11 Apr 2008 11:08:35 +0900 [thread overview]
Message-ID: <47FEC823.9000100@gmail.com> (raw)
In-Reply-To: <A567023C-17FC-402D-9394-29DFFA816891@kernel.crashing.org>
Kumar Gala wrote:
>>> but there is no reason not to make it work properly. For example I
>>> believe libata uses devm_* and the fsl SATA driver (non-PCI) will
>>> need to work in cases similar to the 44x.
>>
>> Well, as for sata_fsl, it calls of_iomap() which does The Right Thing.
>
> Fair, but I don't see why we should introduce new APIs that are already
> "broken". We went through a lot of effort to clean up and introduce
> resource_t (and clearly still have some bugs) for the >32-bit physical
> address problem.
Yes, please go ahead. In case it wasn't clear, I wasn't objecting to
the fix at all. I was just curious what could actually happen on x86.
--
tejun
prev parent reply other threads:[~2008-04-11 2:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11684073371547-git-send-email-htejun@gmail.com>
2008-04-07 16:46 ` [PATCH 6/13] devres: implement managed iomap interface Sergei Shtylyov
2008-04-08 14:48 ` Tejun Heo
2008-04-08 14:55 ` Sergei Shtylyov
2008-04-08 15:03 ` Tejun Heo
2008-04-10 16:56 ` Sergei Shtylyov
2008-04-10 17:44 ` Kumar Gala
2008-04-10 18:24 ` Sergei Shtylyov
2008-04-10 19:40 ` Kumar Gala
2008-04-11 2:08 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FEC823.9000100@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=galak@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).