Flash on LocalBus @ MPC8343

Flash on LocalBus @ MPC8343

[Andre Schwarz]

Hi all,

I've been trying hard to make the mtd-partitions available via device 
tree on my MPC8343 local bus.
No success so far ...

Everything works fine on my MPC5200B based system - flash layout 
definition is quite simple ....

To me it looks like there's a problem regarding the local bus in general.

Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

The other boards use static map files or provide partition over command 
line args .... so suitable dts available.

Flash is 8MB size in 16-Bit configuration and should reside on 
0xFF800000 at cs0.


Any hints ?


regards,
Andre Schwarz
Matrix Vision


dts syntax :

<snip>

        localbus@e0005000 {
                #address-cells = <2>;
                #size-cells = <1>;
                compatible = "fsl,mpc8343-localbus", "fsl,pq2pro-localbus";

                ranges = <0x0 0x0 0xff800000 0x00800000>;

                flash@0,0 {
                        compatible = "amd,s29gl64", "cfi-flash";
                        reg = <0 0 800000>;
                        #address-cells = <1>;
                        #size-cells = <1>;
                        bank-width = <2>;
                        device-width = <2>;

                        ppcboot_env@0 {
                                reg = <0x0 0x2000>;
                        };

<snip>


MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

Re: Flash on LocalBus @ MPC8343

[Laurent Pinchart]

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

On Friday 11 April 2008 17:13, Andre Schwarz wrote:
> Hi all,
> 
> I've been trying hard to make the mtd-partitions available via device 
> tree on my MPC8343 local bus.
> No success so far ...
> 
> Everything works fine on my MPC5200B based system - flash layout 
> definition is quite simple ....
> 
> To me it looks like there's a problem regarding the local bus in general.
> 
> Am I missing a "compatible" or anything else ? "reg" or "ranges" ?
> 
> The other boards use static map files or provide partition over command 
> line args .... so suitable dts available.
> 
> Flash is 8MB size in 16-Bit configuration and should reside on 
> 0xFF800000 at cs0.
> 
> 
> Any hints ?
> 
> 
> regards,
> Andre Schwarz
> Matrix Vision
> 
> 
> dts syntax :
> 
> <snip>
> 
>         localbus@e0005000 {
>                 #address-cells = <2>;
>                 #size-cells = <1>;
>                 compatible = "fsl,mpc8343-localbus", "fsl,pq2pro-localbus";
> 
>                 ranges = <0x0 0x0 0xff800000 0x00800000>;
> 
>                 flash@0,0 {
>                         compatible = "amd,s29gl64", "cfi-flash";
>                         reg = <0 0 800000>;

reg should be <0 0 0x800000>.

>                         #address-cells = <1>;
>                         #size-cells = <1>;
>                         bank-width = <2>;
>                         device-width = <2>;
> 
>                         ppcboot_env@0 {
>                                 reg = <0x0 0x2000>;
>                         };

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Flash on LocalBus @ MPC8343

[Scott Wood]

On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote:
> To me it looks like there's a problem regarding the local bus in general.
>
> Am I missing a "compatible" or anything else ? "reg" or "ranges" ?

Do you have an of_bus_ids[] entry that covers the localbus?

-Scott

Re: Flash on LocalBus @ MPC8343

[André Schwarz]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Scott,

thanks for your help ... but

Scott Wood wrote:
> On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote:
>   
>> To me it looks like there's a problem regarding the local bus in general.
>>
>> Am I missing a "compatible" or anything else ? "reg" or "ranges" ?
>>     
>
> Do you have an of_bus_ids[] entry that covers the localbus?
>
>   
what's this ?
Where do I need to define this ? In dts or platform code ?

Can you give an example ?



regards,
André

> -Scott
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>   



MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

[-- Attachment #2: Type: text/html, Size: 1587 bytes --]

Re: Flash on LocalBus @ MPC8343

[Scott Wood]

André Schwarz wrote:
> Scott,
> 
> thanks for your help ... but
> 
> Scott Wood wrote:
>> On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote:
>>   
>>> To me it looks like there's a problem regarding the local bus in general.
>>>
>>> Am I missing a "compatible" or anything else ? "reg" or "ranges" ?
>>>     
>>
>> Do you have an of_bus_ids[] entry that covers the localbus?
>>
>>   
> what's this ?
> Where do I need to define this ? In dts or platform code ?

Platform code.

> 
> Can you give an example ?

mpc8313erdb.  simple-bus is listed as a compatible for the localbus in 
the dts, and it is listed of_bus_ids[] in the platform file.

-Scott

Re: Flash on LocalBus @ MPC8343

[André Schwarz]

Scott,

thanks , but ... can't find "of_bus_ids[]" entry.
I'm obviously out of sync. My last git-pull from denx is 3 days old, now=20
- need to update on monday.

It seems hard for "normal" people to keep up these days !


Cheers,
Andr=C3=A9


Scott Wood wrote:
> Andr=C3=A9 Schwarz wrote:
>> Scott,
>>
>> thanks for your help ... but
>>
>> Scott Wood wrote:
>>> On Fri, Apr 11, 2008 at 05:13:47PM +0200, Andre Schwarz wrote:
>>> =20
>>>> To me it looks like there's a problem regarding the local bus in=20
>>>> general.
>>>>
>>>> Am I missing a "compatible" or anything else ? "reg" or "ranges" ?
>>>>    =20
>>>
>>> Do you have an of_bus_ids[] entry that covers the localbus?
>>>
>>>  =20
>> what's this ?
>> Where do I need to define this ? In dts or platform code ?
>
> Platform code.
>
>>
>> Can you give an example ?
>
> mpc8313erdb.  simple-bus is listed as a compatible for the localbus in=20
> the dts, and it is listed of_bus_ids[] in the platform file.
>
> -Scott


MATRIX VISION GmbH, Talstra=DFe 16, DE-71570 Oppenweiler  - Registergeric=
ht: Amtsgericht Stuttgart, HRB 271090
Gesch=E4ftsf=FChrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

Re: Flash on LocalBus @ MPC8343

[Scott Wood]

On Sat, Apr 12, 2008 at 10:58:50AM +0200, André Schwarz wrote:
> thanks , but ... can't find "of_bus_ids[]" entry.

That means your platform likely isn't calling of_platform_bus_probe() at
all.  Look at other platforms, such as mpc831x_rdb, for an example.

> I'm obviously out of sync. My last git-pull from denx is 3 days old, now 
> - need to update on monday.

For Denx-specific support, please contact Denx.

This certainly isn't something that was added in the past 3 days.

-Scott

Re: Flash on LocalBus @ MPC8343

[Andre Schwarz]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

Scott,

there has been a "compatible=soc" in my of_bus_id[] ...
It was taken from mpc834x_mds some weeks ago.

I changed to :

static struct of_device_id __initdata of_bus_ids[] = {
        { .compatible = "fsl,pq2pro-localbus", },
        {},
};


now it works fine.


Thanks !

Andre

Scott Wood schrieb:
> On Sat, Apr 12, 2008 at 10:58:50AM +0200, André Schwarz wrote:
>   
>> thanks , but ... can't find "of_bus_ids[]" entry.
>>     
>
> That means your platform likely isn't calling of_platform_bus_probe() at
> all.  Look at other platforms, such as mpc831x_rdb, for an example.
>
>   
>> I'm obviously out of sync. My last git-pull from denx is 3 days old, now 
>> - need to update on monday.
>>     
>
> For Denx-specific support, please contact Denx.
>
> This certainly isn't something that was added in the past 3 days.
>
> -Scott
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>   



MATRIX VISION GmbH, Talstraße 16, DE-71570 Oppenweiler  - Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschäftsführer: Gerhard Thullner, Werner Armingeon, Uwe Furtner

[-- Attachment #2: Type: text/html, Size: 2001 bytes --]

Re: Flash on LocalBus @ MPC8343

[Scott Wood]

On Tue, Apr 15, 2008 at 01:53:56PM +0200, Andre Schwarz wrote:
> Scott,
> 
> there has been a "compatible=soc" in my of_bus_id[] ...
> It was taken from mpc834x_mds some weeks ago.
> 
> I changed to :
> 
> static struct of_device_id __initdata of_bus_ids[] = {
>        { .compatible = "fsl,pq2pro-localbus", },
>        {},
> };

Don't get rid of the soc line, though -- both should be present.

-Scott