From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rob Herring <robh+dt@kernel.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
mad skateman <madskateman@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
"R.T.Dickinson" <rtd2@xtra.co.nz>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
"contact@a-eon.com" <contact@a-eon.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Christian Zigotzky <info@xenosoft.de>
Subject: Re: Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates
Date: Mon, 28 Oct 2019 19:45:34 +1100 [thread overview]
Message-ID: <47e67f44f5e955108759fe32400d2622c4a5ba3f.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAL_JsqLZV1sXc053QMLcV-dV1BbGcRtX3eu1zbtNA_N3hzQE4g@mail.gmail.com>
On Fri, 2019-10-25 at 17:28 -0500, Rob Herring wrote:
> This doesn't work?:
>
> if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev-
> >of_node))
> value |= ESDHC_DMA_SNOOP;
> else
> value &= ~ESDHC_DMA_SNOOP;
CONFIG_PPC is restrictive. What about sparc64 ? There could be others
.. .we can't suddenly requests people to add new properties for what
was implied behaviours before hand, esp since it's not in the base 1275
spec, no ?
I would suggest of_dma_is_coherent is *true* by default unless
overriden to do something else.
Cheers,
Ben.
next prev parent reply other threads:[~2019-10-28 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7b549219-a2e1-08c7-331b-9c3e4fdb8a8f@xenosoft.de>
[not found] ` <3aeae0d8-e9be-2585-cbbd-70263cb495f1@xenosoft.de>
[not found] ` <20191015125105.GU25745@shell.armlinux.org.uk>
[not found] ` <5611f3bc-68aa-78ec-182a-1cb414202314@xenosoft.de>
[not found] ` <20191015131750.GV25745@shell.armlinux.org.uk>
2019-10-23 5:42 ` Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates Michael Ellerman
2019-10-23 6:41 ` Benjamin Herrenschmidt
2019-10-23 13:52 ` Rob Herring
2019-10-23 14:12 ` Russell King - ARM Linux admin
2019-10-23 14:31 ` Russell King - ARM Linux admin
2019-10-25 22:28 ` Rob Herring
2019-10-26 6:39 ` Christoph Hellwig
2019-10-28 8:47 ` Benjamin Herrenschmidt
2019-10-28 8:45 ` Benjamin Herrenschmidt [this message]
2019-10-23 14:20 ` Christian Zigotzky
2019-11-04 14:44 ` Christian Zigotzky
2019-11-05 7:50 ` Bug 205201 - overflow of DMA mask and bus mask Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e67f44f5e955108759fe32400d2622c4a5ba3f.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=chzigotzky@xenosoft.de \
--cc=contact@a-eon.com \
--cc=info@xenosoft.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madskateman@gmail.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=rtd2@xtra.co.nz \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).