* [PATCH] ocxl: Fix access to the AFU Descriptor Data
@ 2018-08-13 9:01 Christophe Lombard
2018-08-13 9:48 ` Andrew Donnellan
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Lombard @ 2018-08-13 9:01 UTC (permalink / raw)
To: linuxppc-dev, fbarrat, vaibhav, andrew.donnellan
From: Christophe Lombard <christophe_lombard@fr.ibm.cm>
The AFU Information DVSEC capability is a means to extract common,
general information about all of the AFUs associated with a Function
independent of the specific functionality that each AFU provides.
This patch fixes the access to the AFU Descriptor Data indexed by the
AFU Info Index field.
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
---
drivers/misc/ocxl/config.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
index 2e30de9..de01623 100644
--- a/drivers/misc/ocxl/config.c
+++ b/drivers/misc/ocxl/config.c
@@ -280,7 +280,9 @@ int ocxl_config_check_afu_index(struct pci_dev *dev,
u32 val;
int rc, templ_major, templ_minor, len;
- pci_write_config_word(dev, fn->dvsec_afu_info_pos, afu_idx);
+ pci_write_config_word(dev,
+ fn->dvsec_afu_info_pos + OCXL_DVSEC_AFU_INFO_AFU_IDX,
+ afu_idx);
rc = read_afu_info(dev, fn, OCXL_DVSEC_TEMPL_VERSION, &val);
if (rc)
return rc;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ocxl: Fix access to the AFU Descriptor Data
2018-08-13 9:01 [PATCH] ocxl: Fix access to the AFU Descriptor Data Christophe Lombard
@ 2018-08-13 9:48 ` Andrew Donnellan
2018-08-13 10:21 ` Frederic Barrat
2018-08-13 13:42 ` christophe lombard
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Donnellan @ 2018-08-13 9:48 UTC (permalink / raw)
To: Christophe Lombard, linuxppc-dev, fbarrat, vaibhav
On 13/08/18 19:01, Christophe Lombard wrote:
> From: Christophe Lombard <christophe_lombard@fr.ibm.cm>
Your git committer email should probably match your sign-off email.
>
> The AFU Information DVSEC capability is a means to extract common,
> general information about all of the AFUs associated with a Function
> independent of the specific functionality that each AFU provides.
>
> This patch fixes the access to the AFU Descriptor Data indexed by the
> AFU Info Index field.
>
> Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
>
> Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
This looks like it should go to stable? I assume the reason we haven't
noticed this previously is because we have not been testing with
multi-AFU cards.
> ---
> drivers/misc/ocxl/config.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
> index 2e30de9..de01623 100644
> --- a/drivers/misc/ocxl/config.c
> +++ b/drivers/misc/ocxl/config.c
> @@ -280,7 +280,9 @@ int ocxl_config_check_afu_index(struct pci_dev *dev,
> u32 val;
> int rc, templ_major, templ_minor, len;
>
> - pci_write_config_word(dev, fn->dvsec_afu_info_pos, afu_idx);
> + pci_write_config_word(dev,
> + fn->dvsec_afu_info_pos + OCXL_DVSEC_AFU_INFO_AFU_IDX,
> + afu_idx);
pci_write_config_byte() would be more appropriate here (see
ocxl_config_read_afu() at line 454)
> rc = read_afu_info(dev, fn, OCXL_DVSEC_TEMPL_VERSION, &val);
> if (rc)
> return rc;
>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ocxl: Fix access to the AFU Descriptor Data
2018-08-13 9:48 ` Andrew Donnellan
@ 2018-08-13 10:21 ` Frederic Barrat
2018-08-13 13:42 ` christophe lombard
1 sibling, 0 replies; 4+ messages in thread
From: Frederic Barrat @ 2018-08-13 10:21 UTC (permalink / raw)
To: Andrew Donnellan, Christophe Lombard, linuxppc-dev, fbarrat,
vaibhav
Le 13/08/2018 à 11:48, Andrew Donnellan a écrit :
> On 13/08/18 19:01, Christophe Lombard wrote:
>> From: Christophe Lombard <christophe_lombard@fr.ibm.cm>
>
> Your git committer email should probably match your sign-off email.
>
>>
>> The AFU Information DVSEC capability is a means to extract common,
>> general information about all of the AFUs associated with a Function
>> independent of the specific functionality that each AFU provides.
>>
>> This patch fixes the access to the AFU Descriptor Data indexed by the
>> AFU Info Index field.
>>
>> Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
>>
>> Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
>
> This looks like it should go to stable? I assume the reason we haven't
> noticed this previously is because we have not been testing with
> multi-AFU cards.
Yes, it's hidden until we have more than one AFU per function. Also, the
field we overwrite at the wrong offset is read-only, so it goes undetected.
Fred
>
>> ---
>> drivers/misc/ocxl/config.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
>> index 2e30de9..de01623 100644
>> --- a/drivers/misc/ocxl/config.c
>> +++ b/drivers/misc/ocxl/config.c
>> @@ -280,7 +280,9 @@ int ocxl_config_check_afu_index(struct pci_dev *dev,
>> u32 val;
>> int rc, templ_major, templ_minor, len;
>> - pci_write_config_word(dev, fn->dvsec_afu_info_pos, afu_idx);
>> + pci_write_config_word(dev,
>> + fn->dvsec_afu_info_pos + OCXL_DVSEC_AFU_INFO_AFU_IDX,
>> + afu_idx);
>
> pci_write_config_byte() would be more appropriate here (see
> ocxl_config_read_afu() at line 454)
>
>> rc = read_afu_info(dev, fn, OCXL_DVSEC_TEMPL_VERSION, &val);
>> if (rc)
>> return rc;
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ocxl: Fix access to the AFU Descriptor Data
2018-08-13 9:48 ` Andrew Donnellan
2018-08-13 10:21 ` Frederic Barrat
@ 2018-08-13 13:42 ` christophe lombard
1 sibling, 0 replies; 4+ messages in thread
From: christophe lombard @ 2018-08-13 13:42 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev, fbarrat, vaibhav
Le 13/08/2018 à 11:48, Andrew Donnellan a écrit :
> On 13/08/18 19:01, Christophe Lombard wrote:
>> From: Christophe Lombard <christophe_lombard@fr.ibm.cm>
>
> Your git committer email should probably match your sign-off email.
>
>>
>> The AFU Information DVSEC capability is a means to extract common,
>> general information about all of the AFUs associated with a Function
>> independent of the specific functionality that each AFU provides.
>>
>> This patch fixes the access to the AFU Descriptor Data indexed by the
>> AFU Info Index field.
>>
>> Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
>>
>> Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
>
> This looks like it should go to stable? I assume the reason we haven't
> noticed this previously is because we have not been testing with
> multi-AFU cards.
>
>> ---
>> drivers/misc/ocxl/config.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c
>> index 2e30de9..de01623 100644
>> --- a/drivers/misc/ocxl/config.c
>> +++ b/drivers/misc/ocxl/config.c
>> @@ -280,7 +280,9 @@ int ocxl_config_check_afu_index(struct pci_dev *dev,
>> u32 val;
>> int rc, templ_major, templ_minor, len;
>> - pci_write_config_word(dev, fn->dvsec_afu_info_pos, afu_idx);
>> + pci_write_config_word(dev,
>> + fn->dvsec_afu_info_pos + OCXL_DVSEC_AFU_INFO_AFU_IDX,
>> + afu_idx);
>
> pci_write_config_byte() would be more appropriate here (see
> ocxl_config_read_afu() at line 454)
>
>> rc = read_afu_info(dev, fn, OCXL_DVSEC_TEMPL_VERSION, &val);
>> if (rc)
>> return rc;
>>
>
right. Thanks for the review.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-13 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-13 9:01 [PATCH] ocxl: Fix access to the AFU Descriptor Data Christophe Lombard
2018-08-13 9:48 ` Andrew Donnellan
2018-08-13 10:21 ` Frederic Barrat
2018-08-13 13:42 ` christophe lombard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).