From: Jiri Slaby <jirislaby@gmail.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
York Sun <yorksun@freescale.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU
Date: Mon, 14 Apr 2008 16:24:10 +0200 [thread overview]
Message-ID: <4803690A.3080105@gmail.com> (raw)
In-Reply-To: <48036649.6000409@freescale.com>
On 04/14/2008 04:12 PM, Timur Tabi wrote:
> Unfortunately, the author of the patch, York, is out this week, so I'll have to
> take care of this. It'd be easier to modify rh_alloc() so that it doesn't
> sleep, so that's what I'm going to do.
Anyway, why do you need the spin lock there (and not mutex)? As I think you are
still trying to avoid the problem instead of fixing it. Removing GFP_WAIT
(fsl_diu_alloc) doesn't seem to me as mm friendly solution, especially if you
allocate that much memory and you can sleep. But I might be wrong, you may need
the spinlock...
next prev parent reply other threads:[~2008-04-14 14:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 21:43 Driver for Freescale Display Interface Unit (A LCD controller) York Sun
2008-03-12 21:43 ` [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU York Sun
2008-03-12 21:43 ` [PATCH 2/2] Add DIU platform code for MPC8610HPCD York Sun
2008-04-14 14:18 ` Arnd Bergmann
2008-03-12 22:20 ` [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU Jiri Slaby
2008-04-11 21:45 ` Jiri Slaby
2008-04-12 5:18 ` Andrew Morton
2008-04-14 13:39 ` Timur Tabi
2008-04-14 13:43 ` Jiri Slaby
2008-04-14 13:45 ` Timur Tabi
2008-04-14 13:54 ` Jiri Slaby
2008-04-14 14:12 ` Timur Tabi
2008-04-14 14:24 ` Jiri Slaby [this message]
2008-04-14 14:49 ` Timur Tabi
2008-04-14 15:43 ` Jiri Slaby
2008-04-14 15:46 ` Timur Tabi
2008-04-14 19:03 ` Andrew Morton
2008-03-13 0:10 ` Stephen Rothwell
2008-03-13 10:17 ` Driver for Freescale Display Interface Unit (A LCD controller) Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4803690A.3080105@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
--cc=yorksun@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).