linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] Make rheap safe for spinlocks
Date: Mon, 14 Apr 2008 15:02:14 -0500	[thread overview]
Message-ID: <4803B846.4010009@freescale.com> (raw)
In-Reply-To: <30C5925E-31F7-4E52-95C9-43DB0DE68A9F@kernel.crashing.org>

Kumar Gala wrote:

> Is this need to fix a bug with an existing driver of for a new driver?

Both.  The ucc_geth driver calls qe_muram_alloc() with spinlocks held.  The 8610
DIU driver does something similar, but it's targeted for 2.6.26.

I'm hesitant to recommend inclusion in 2.6.25 because I haven't tested the fix
throughly enough to know that it doesn't break something else.  Technically, it
could result in qe_muram_alloc() failing.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2008-04-14 20:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 15:43 [PATCH] Make rheap safe for spinlocks Timur Tabi
2008-04-14 19:58 ` Kumar Gala
2008-04-14 20:02   ` Timur Tabi [this message]
2008-04-17 14:57 ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4803B846.4010009@freescale.com \
    --to=timur@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).