linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Paul Mackerras <paulus@samba.org>, Linux I2C <i2c@lm-sensors.org>,
	"linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>
Subject: Re: build breakage from of i2c helper patch
Date: Thu, 17 Apr 2008 11:25:12 +0200	[thread overview]
Message-ID: <48071778.2000405@scram.de> (raw)
In-Reply-To: <CDDD8C0A-4B40-4CA7-BB84-50B2A93C7804@kernel.crashing.org>

Hi Kumar,

> I'm guessing the "[POWERPC] i2c: OF helpers for the i2c API"
> 
> http://git.kernel.org/?p=linux/kernel/git/paulus/powerpc.git;a=commitdiff;h=612212a3f2f053ea68ce9cd16d3deeca7754e8c9
> 
> is causing this build failure:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/24375/

It looks like it. i2c-core needs to be compiled static for the OF bindings to work.
I guess in Kconfig "depends on OF && I2C" must be changed into "depends on OF && (I2C=y)"

On the other hand, i didn't test the patch without the dependent patches, so it might not work as expected:

http://patchwork.ozlabs.org/linuxppc/patch?id=17833
http://patchwork.ozlabs.org/linuxppc/patch?id=17834

or the original ones from Jean Delvare:

http://patchwork.ozlabs.org/linuxppc/patch?id=16282
http://patchwork.ozlabs.org/linuxppc/patch?id=16283
http://patchwork.ozlabs.org/linuxppc/patch?id=16284

Thanks,
Jochen

  reply	other threads:[~2008-04-17  9:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17  7:11 build breakage from of i2c helper patch Kumar Gala
2008-04-17  9:25 ` Jochen Friedrich [this message]
2008-04-17  9:37   ` Jean Delvare
2008-04-18 12:27     ` Jochen Friedrich
2008-04-18 11:27   ` Paul Mackerras
2008-04-18 12:35     ` Jochen Friedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48071778.2000405@scram.de \
    --to=jochen@scram.de \
    --cc=galak@kernel.crashing.org \
    --cc=i2c@lm-sensors.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).