linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: "linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Paul Mackerras <paulus@samba.org>, Linux I2C <i2c@lm-sensors.org>
Subject: Re: build breakage from of i2c helper patch
Date: Fri, 18 Apr 2008 14:27:52 +0200	[thread overview]
Message-ID: <480893C8.6020300@scram.de> (raw)
In-Reply-To: <20080417113703.0f24c578@hyperion.delvare>

Hi Jean,

> (blind shot) Maybe this means that some code that is in i2c-core should
> be moved to i2c-boardinfo instead? i2c-boardinfo is always built into
> the kernel even when i2c-core is modular.

unfortunately, i2c_new_device() tries to attach the module, so this function
really needs full i2c-core functionality.

I think the best way to fix this is to make the OF helpers def_tristate I2C, so
it will be compiled as module if i2c-core is compiled as module, as well.

I'll send an updated patch in a minute.

Thanks,
Jochen

  reply	other threads:[~2008-04-18 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17  7:11 build breakage from of i2c helper patch Kumar Gala
2008-04-17  9:25 ` Jochen Friedrich
2008-04-17  9:37   ` Jean Delvare
2008-04-18 12:27     ` Jochen Friedrich [this message]
2008-04-18 11:27   ` Paul Mackerras
2008-04-18 12:35     ` Jochen Friedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480893C8.6020300@scram.de \
    --to=jochen@scram.de \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).