From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <12o3l@tiscali.nl> Received: from smtp-out3.tiscali.nl (smtp-out3.tiscali.nl [195.241.79.178]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9B5F0DE2BE for ; Thu, 24 Apr 2008 05:00:45 +1000 (EST) Message-ID: <480F8754.7000200@tiscali.nl> Date: Wed, 23 Apr 2008 21:00:36 +0200 From: Roel Kluin <12o3l@tiscali.nl> MIME-Version: 1.0 To: paulus@samba.org, linuxppc-dev@ozlabs.org Subject: [PATCH 2/2] mpic_u3msi: mpic_u3msi: failed allocation unnoticed References: <480F6905.3070808@tiscali.nl> In-Reply-To: <480F6905.3070808@tiscali.nl> Content-Type: text/plain; charset=ISO-8859-1 Cc: lkml List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , A similar problem in arch/powerpc/sysdev/mpic_u3msi.c, sorry for the dup, fixed header. --- bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may return -ENOMEM, but hwirq of type irq_hw_number_t which is unsigned. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- The functions can be found respectively in: //---[ vi lib/bitmap.c +807 ]--- //---[ vi arch/powerpc/sysdev/mpic_msi.c +39 ]--- diff --git a/arch/powerpc/sysdev/mpic_u3msi.c b/arch/powerpc/sysdev/mpic_u3msi.c index 1d5a408..30a4e27 100644 --- a/arch/powerpc/sysdev/mpic_u3msi.c +++ b/arch/powerpc/sysdev/mpic_u3msi.c @@ -122,7 +122,7 @@ static int u3msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) list_for_each_entry(entry, &pdev->msi_list, list) { hwirq = mpic_msi_alloc_hwirqs(msi_mpic, 1); - if (hwirq < 0) { + if (hwirq == -ENOMEM) { pr_debug("u3msi: failed allocating hwirq\n"); return hwirq; }