From: Jeff Garzik <jgarzik@pobox.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/6] ibm_newemac: Fix problem with jumbo frame support and EMAC V4.patch
Date: Fri, 25 Apr 2008 02:01:37 -0400 [thread overview]
Message-ID: <481173C1.8060300@pobox.com> (raw)
In-Reply-To: <20080422004758.1A823DE19B@ozlabs.org>
Benjamin Herrenschmidt wrote:
> From: Stefan Roese <sr@denx.de>
>
> This fixes the jumbo frame support on EMAC V4 systems. Now the correct
> bit is set depending on the EMAC version configured.
>
> Tested on Kilauea (405EX) and Canyonlands (460EX).
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> ---
> drivers/net/ibm_newemac/core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 0789802..486901f 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -524,7 +524,10 @@ static int emac_configure(struct emac_instance *dev)
> rx_size = dev->rx_fifo_size_gige;
>
> if (dev->ndev->mtu > ETH_DATA_LEN) {
> - mr1 |= EMAC_MR1_JPSM;
> + if (emac_has_feature(dev, EMAC_FTR_EMAC4))
> + mr1 |= EMAC4_MR1_JPSM;
> + else
> + mr1 |= EMAC_MR1_JPSM;
> dev->stop_timeout = STOP_TIMEOUT_1000_JUMBO;
> } else
> dev->stop_timeout = STOP_TIMEOUT_1000;
applied 1-6
prev parent reply other threads:[~2008-04-25 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 0:46 [PATCH 1/6] ibm_newemac: Fix problem with jumbo frame support and EMAC V4.patch Benjamin Herrenschmidt
2008-04-25 6:01 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481173C1.8060300@pobox.com \
--to=jgarzik@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).