linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: "Kernel, Linux" <linux-kernel@vger.kernel.org>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Scott Wood <scottwood@freescale.com>,
	Linux I2C <i2c@lm-sensors.org>
Subject: Re: [PATCH1/7] i2c: Add support for device alias names
Date: Sun, 27 Apr 2008 13:07:39 +0200	[thread overview]
Message-ID: <48145E7B.6040805@scram.de> (raw)
In-Reply-To: <20080426223815.16e38a85@hyperion.delvare>

Hi Jean,

>> -	if ((err = f75375_probe(client)) < 0)
>> +	err = f75375_probe(client, NULL);
>> +	if (err < 0)
>>  		goto exit_detach;
>>  
>>  	return 0;
> 
> These coding style cleanups don't belong to this patch (if they belong
> anywhere - I don't much see the point)

I just wanted to make sure, scripts/checkpatch.pl doesn't complain.
But you're right. The coding style cleanup should have been another patch.

Thanks a lot for your efforts of getting the alias stuff in!

Jochen

      reply	other threads:[~2008-04-27 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11 14:07 [PATCH1/7] i2c: Add support for device alias names Jochen Friedrich
2008-04-26 20:38 ` Jean Delvare
2008-04-27 11:07   ` Jochen Friedrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48145E7B.6040805@scram.de \
    --to=jochen@scram.de \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).