From: Timur Tabi <timur@freescale.com>
To: cbouatmailru@gmail.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Date: Wed, 30 Apr 2008 18:03:45 -0500 [thread overview]
Message-ID: <4818FAD1.8020808@freescale.com> (raw)
In-Reply-To: <20080430225951.GA10361@zarina>
Anton Vorontsov wrote:
> What is the problem with returning (int)(u32 & u32) value?
Technically, a signed int is smaller than an unsigned int, so a value of
0x80000000 won't fit in an 'int'.
> You've asked to remove "!!" stuff and now purposing exactly the
> same... :-?
The !! stuff was because the function was returning a boolean value, so non-zero
== TRUE. I don't think the return value from 'get' is a technically a boolean,
so I'm assuming that the spec says the return value should be 0 or 1, to reflect
the value of that GPIO pin.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-04-30 23:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 18:59 [PATCH 0/6 v4] Few more patches for Kumar's powerpc.git Anton Vorontsov
2008-04-29 19:00 ` [PATCH 1/6] [POWERPC] sysdev: implement FSL GTM support Anton Vorontsov
2008-05-01 4:00 ` Kumar Gala
2008-05-01 11:43 ` Anton Vorontsov
2008-04-29 19:00 ` [PATCH 2/6] [POWERPC] QE: add support for QE USB clocks routing Anton Vorontsov
2008-04-29 19:57 ` Timur Tabi
2008-04-29 21:22 ` Anton Vorontsov
2008-04-29 19:00 ` [PATCH 3/6] [POWERPC] QE: prepare QE PIO code for GPIO LIB support Anton Vorontsov
2008-04-29 20:10 ` Timur Tabi
2008-04-29 19:00 ` [PATCH 4/6] [POWERPC] QE: implement support for the GPIO LIB API Anton Vorontsov
2008-04-29 20:29 ` Timur Tabi
2008-04-29 21:23 ` Anton Vorontsov
2008-04-29 21:29 ` Timur Tabi
2008-04-30 19:30 ` [PATCH v2 " Anton Vorontsov
2008-04-30 19:42 ` Timur Tabi
2008-04-30 22:47 ` Anton Vorontsov
2008-04-30 22:50 ` Timur Tabi
2008-04-30 22:59 ` Anton Vorontsov
2008-04-30 23:03 ` Timur Tabi [this message]
2008-04-30 23:24 ` Anton Vorontsov
2008-05-01 14:33 ` Timur Tabi
2008-05-01 14:33 ` Timur Tabi
2008-04-29 19:00 ` [PATCH 5/6] [POWERPC] 83xx: new board support: MPC8360E-RDK Anton Vorontsov
2008-06-10 15:55 ` Kumar Gala
2008-06-10 19:32 ` [PATCH] powerpc: 83xx: update mpc83xx_defconfig to support MPC8360E-RDK Anton Vorontsov
2008-06-10 22:01 ` Kumar Gala
2008-06-10 23:16 ` [PATCH v2] powerpc/83xx: " Anton Vorontsov
2008-06-11 12:47 ` [PATCH v3] " Anton Vorontsov
2008-04-29 19:00 ` [PATCH 6/6] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings Anton Vorontsov
2008-04-30 8:36 ` Wolfgang Grandegger
2008-04-30 11:16 ` Anton Vorontsov
2008-04-30 13:19 ` Wolfgang Grandegger
2008-04-30 14:07 ` Anton Vorontsov
2008-04-30 17:26 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4818FAD1.8020808@freescale.com \
--to=timur@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).