From: Scott Wood <scottwood@freescale.com>
To: Andy Fleming <afleming@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib
Date: Fri, 02 May 2008 13:07:44 -0500 [thread overview]
Message-ID: <481B5870.2010000@freescale.com> (raw)
In-Reply-To: <1209751415-25612-1-git-send-email-afleming@freescale.com>
Andy Fleming wrote:
> + struct qe_iram __iomem iram; /* I-RAM */
> + struct qe_ic_regs __iomem ic; /* Interrupt Controller */
> + struct cp_qe __iomem cp; /* Communications Processor */
> + struct qe_mux __iomem qmx; /* QE Multiplexer */
> + struct qe_timers __iomem qet; /* QE Timers */
> + struct spi __iomem spi[0x2]; /* spi */
> + struct mcc __iomem mcc; /* mcc */
> + struct qe_brg __iomem brg; /* brg */
> + struct usb_ctlr __iomem usb; /* USB */
> + struct si1 __iomem si1; /* SI */
Why not just set __iomem on qe_immap references?
-Scott
next prev parent reply other threads:[~2008-05-02 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:03 [PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib Andy Fleming
2008-05-02 18:07 ` Scott Wood [this message]
2008-05-02 23:59 ` Andy Fleming
2008-05-02 18:37 ` Timur Tabi
2008-05-03 0:00 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481B5870.2010000@freescale.com \
--to=scottwood@freescale.com \
--cc=afleming@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).