From: Jochen Friedrich <jochen@scram.de>
To: Paul Mackerras <paulus@samba.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
"Kernel, Linux" <linux-kernel@vger.kernel.org>,
Scott Wood <scottwood@freescale.com>,
Linux I2C <i2c@lm-sensors.org>, Jean Delvare <khali@linux-fr.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [POWERPC] Fix of_i2c include for module compilation
Date: Tue, 06 May 2008 20:39:37 +0200 [thread overview]
Message-ID: <4820A5E9.8030204@scram.de> (raw)
In-Reply-To: <18462.35282.374180.770237@cargo.ozlabs.ibm.com>
Hi Paul,
>> -#ifdef CONFIG_OF_I2C
>> +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE)
>>
>> void of_register_i2c_devices(struct i2c_adapter *adap,
>> struct device_node *adap_node);
>
> Why do we have that ifdef there at all? There's only that one
> external declaration within it, so the #ifdef and #endif could just be
> removed. If the ifdef hadn't been there in the first place we
> wouldn't have had this problem.
You're right. I mainly copied from of_gpio.h without too much thinking :(.
I'll resend.
Thanks,
Jochen
prev parent reply other threads:[~2008-05-06 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 12:42 [PATCH] [POWERPC] Fix of_i2c include for module compilation Jochen Friedrich
2008-05-05 4:15 ` Paul Mackerras
2008-05-06 18:39 ` Jochen Friedrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4820A5E9.8030204@scram.de \
--to=jochen@scram.de \
--cc=davem@davemloft.net \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).