From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linuxppc-dev@lists.ozlabs.org
Cc: Michael Neuling <michael.neuling@au1.ibm.com>
Subject: [PATCH] powerpc: Ensure gcc doesn't move around cache flushing in __patch_instruction
Date: Thu, 17 May 2018 13:06:10 +1000 [thread overview]
Message-ID: <48284701fe497bb4f5bede5c55bbce9d70309562.camel@kernel.crashing.org> (raw)
The current asm statement in __patch_instruction() for the cache flushes
doesn't have a "volatile" statement and no memory clobber. That means
gcc can potentially move it around (or move the store done by put_user
past the flush).
Add both to ensure gcc doesn't play games.
Found by code inspection, no actual bug reported.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
--- a/arch/powerpc/lib/code-patching.c
+++ b/arch/powerpc/lib/code-patching.c
@@ -32,8 +32,9 @@ static int __patch_instruction(unsigned int *exec_addr, unsigned int instr,
if (err)
return err;
- asm ("dcbst 0, %0; sync; icbi 0,%1; sync; isync" :: "r" (patch_addr),
- "r" (exec_addr));
+ asm volatile("dcbst 0, %0; sync; icbi 0,%1; sync; isync"
+ :: "r" (patch_addr), "r" (exec_addr)
+ : "memory");
return 0;
}
next reply other threads:[~2018-05-17 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 3:06 Benjamin Herrenschmidt [this message]
2018-05-17 19:23 ` [PATCH] powerpc: Ensure gcc doesn't move around cache flushing in __patch_instruction Segher Boessenkool
2018-05-17 22:30 ` Benjamin Herrenschmidt
2018-05-17 23:00 ` Segher Boessenkool
2019-01-31 13:20 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48284701fe497bb4f5bede5c55bbce9d70309562.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael.neuling@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).