linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: netdev@vger.kernel.org, adrian.bunk@movial.fi,
	Jeff Garzik <jeff@garzik.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [RFC] Make board force selection of PHYLIB
Date: Tue, 03 Jun 2008 10:18:24 -0500	[thread overview]
Message-ID: <484560C0.2080607@freescale.com> (raw)
In-Reply-To: <57B740A4-A3E0-4D93-A5D9-77B14C6E9E92@kernel.crashing.org>

Kumar Gala wrote:
> On Jun 3, 2008, at 10:10 AM, Scott Wood wrote:
>> I'd rather avoid adding another case where the kernel needs to know 
>> what modules are being built, though, especially if the result of 
>> changing the .config and building modules is a mysterious runtime 
>> failure (due to a missing platform fixup) rather than compile- or 
>> insertion-time.
> 
> I don't follow what you are getting at here.  Is this something more 
> than #ifdef PHYLIB in the platform code?

If you just #ifdef PHYLIB, then things will break if the user does this:
make config, GIANFAR=PHYLIB=n
make zImage
make config, GIANFAR=PHYLIB=m
make modules

And the cause of the failure will not be something that obviously points 
to a build problem, such as unresolved symbols.

I'd rather just unconditionally select PHYLIB on platforms that need to 
do fixups.

-Scott

  reply	other threads:[~2008-06-03 15:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 15:58 [PATCH] phylib: Don't allow core of phylib to build as a module Kumar Gala
2008-06-02 16:03 ` Jeff Garzik
2008-06-02 16:25   ` Kumar Gala
2008-06-02 16:32     ` Scott Wood
2008-06-02 16:39     ` Jeff Garzik
2008-06-02 19:19       ` Kumar Gala
2008-06-02 20:29         ` Jeff Garzik
2008-06-02 23:06           ` Kumar Gala
2008-06-02 19:30       ` Kumar Gala
2008-06-02 19:44         ` Andy Fleming
2008-06-02 20:30           ` Jeff Garzik
2008-06-02 23:07             ` Kumar Gala
2008-06-02 23:20               ` Scott Wood
2008-06-03 14:47                 ` [RFC] Make board force selection of PHYLIB Kumar Gala
2008-06-03 15:10                   ` Scott Wood
2008-06-03 15:14                     ` Kumar Gala
2008-06-03 15:18                       ` Scott Wood [this message]
2008-06-03 15:31                         ` Kumar Gala
2008-06-03 15:36                           ` Scott Wood
2008-06-03 15:40                             ` Kumar Gala
2008-06-03 15:56                               ` Scott Wood
2008-06-03 18:07                           ` Andy Fleming
2008-06-03 17:00                   ` Adrian Bunk
2008-06-03 18:11                     ` Andy Fleming
2008-06-03 18:23                     ` Kumar Gala
2008-06-06 15:19                 ` [PATCH] phylib: Don't allow core of phylib to build as a module Grant Likely
2008-06-02 16:54     ` Adrian Bunk
2008-06-02 19:24       ` Kumar Gala
2008-06-06 15:40         ` [PATCH] [POWERPC] 85xx: MPC85xx MDS - Unconditionally select PHYLIB for board fixups Kumar Gala
2008-06-06 17:48           ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484560C0.2080607@freescale.com \
    --to=scottwood@freescale.com \
    --cc=adrian.bunk@movial.fi \
    --cc=galak@kernel.crashing.org \
    --cc=jeff@garzik.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).