linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>, Stefan Roese <sr@denx.de>,
	linuxppc-dev@ozlabs.org
Subject: Re: "cell-index" vs. "index" vs. no index in I2C device nodes
Date: Thu, 05 Jun 2008 11:09:16 -0500	[thread overview]
Message-ID: <48480FAC.3020406@freescale.com> (raw)
In-Reply-To: <935d90b908261c8e5862caeeb1f396aa@kernel.crashing.org>

Segher Boessenkool wrote:

> Sounds to me like both simply need to use adapter->nr. 

How can a non-I2C driver get the adapter structure for another driver that is an
I2C driver?

> For access to
> Linux-internal data structures (and that is what this "index" is), you
> shouldn't have to go via the device tree.  If the Linux data structures
> do not have the information you need, well, fix that.

The fabric driver doesn't have access to any I2C structures when it starts
looking for the codec driver.  The fabric driver is like an OF platform driver,
in that it's OF-aware and machine-specific.  By parsing the device tree (which
is the only tool I have to know how the board is laid out), the fabric driver
can determine that SSI1 is attached to a CS4270 on I2C bus #1, address 0x4F.
That's the only information it has.

The CS4270 driver, on the other hand, knows nothing about OF.  It just knows
whatever is passed to its I2C probe function, i.e. the i2c_adapter and
i2c_client structures.

So in order for the two drivers to be able to link to each other, there needs to
be some code that takes data from the device tree and places it into the I2C
data structures.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2008-06-05 16:09 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04 15:06 "cell-index" vs. "index" vs. no index in I2C device nodes Stefan Roese
2008-06-04 15:24 ` Timur Tabi
2008-06-04 15:43   ` Scott Wood
2008-06-05  2:19     ` Josh Boyer
2008-06-05  2:41       ` David Gibson
2008-06-06  2:40         ` Segher Boessenkool
2008-06-06  3:37           ` David Gibson
2008-06-07  0:30             ` Segher Boessenkool
2008-06-06  4:07         ` Grant Likely
2008-06-06  4:29           ` Sean MacLennan
2008-06-05  2:54       ` Sean MacLennan
2008-06-05  3:05         ` Josh Boyer
2008-06-05  3:16           ` Sean MacLennan
2008-06-05  6:22             ` Stefan Roese
2008-06-05  7:48               ` Jean Delvare
2008-06-05  8:45                 ` Stefan Roese
2008-06-05 10:57                   ` David Gibson
2008-06-05 11:52                   ` Josh Boyer
2008-06-05 15:18                     ` Timur Tabi
2008-06-05 22:47                     ` David Gibson
2008-06-06  4:17                   ` Benjamin Herrenschmidt
2008-06-06  4:16                 ` Benjamin Herrenschmidt
2008-06-06  6:21                   ` Jean Delvare
2008-06-06  7:47                     ` Grant Likely
2008-06-06  8:45                     ` Benjamin Herrenschmidt
2008-06-05 15:17               ` Timur Tabi
2008-06-05 15:44                 ` Jochen Friedrich
2008-06-05 15:50                   ` Timur Tabi
2008-06-05 16:10                     ` Grant Likely
2008-06-05 16:18                       ` Timur Tabi
2008-06-05 16:22                         ` Jochen Friedrich
2008-06-05 16:30                           ` Grant Likely
2008-06-05 16:40                             ` Timur Tabi
2008-06-05 22:46                               ` David Gibson
2008-06-05 16:35                         ` Grant Likely
2008-06-05 23:59                     ` Josh Boyer
2008-06-07  0:24                       ` Segher Boessenkool
2008-06-05 21:37               ` Sean MacLennan
2008-06-05 23:48                 ` Josh Boyer
2008-06-05 15:13       ` Timur Tabi
2008-06-05 15:39         ` Grant Likely
2008-06-05 15:43           ` Timur Tabi
2008-06-05 15:52             ` Segher Boessenkool
2008-06-05 16:09               ` Timur Tabi [this message]
2008-06-05 16:27                 ` Scott Wood
2008-06-05 17:52                   ` Timur Tabi
2008-06-05 18:04                     ` Scott Wood
2008-06-05 16:00             ` Grant Likely
2008-06-05 16:13               ` Timur Tabi
2008-06-05 16:21                 ` Josh Boyer
2008-06-05 16:25                   ` Timur Tabi
2008-06-05 16:37                     ` Grant Likely
2008-06-05 18:27                     ` Josh Boyer
2008-06-05 18:35                       ` Timur Tabi
2008-06-05 18:40                         ` Josh Boyer
2008-06-05 18:46                       ` Grant Likely
2008-06-05 18:56                         ` Josh Boyer
2008-06-05 19:14                           ` Grant Likely
2008-06-05 19:15                             ` Josh Boyer
2008-06-05 19:16                             ` Timur Tabi
2008-06-05 21:31                               ` Segher Boessenkool
2008-06-05 22:56                               ` David Gibson
2008-06-06 13:09                                 ` Timur Tabi
2008-06-06 13:42                                   ` Stefan Roese
2008-06-05 22:45                             ` Sean MacLennan
2008-06-06  4:20             ` Benjamin Herrenschmidt
2008-06-25 21:46               ` Timur Tabi
2008-06-27 16:48                 ` Jochen Friedrich
2008-06-05 15:46           ` Segher Boessenkool
2008-06-05 15:52           ` Jochen Friedrich
2008-06-05 15:53             ` Grant Likely
2008-06-06  4:19         ` Benjamin Herrenschmidt
2008-06-06  4:14       ` Benjamin Herrenschmidt
2008-06-06  4:13     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48480FAC.3020406@freescale.com \
    --to=timur@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=segher@kernel.crashing.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).