From: Scott Wood <scottwood@freescale.com>
To: hs@denx.de
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [8xx] powerpc: Add support for the MPC852 based mgsuvd board from keymile.
Date: Fri, 13 Jun 2008 10:51:23 -0500 [thread overview]
Message-ID: <4852977B.8030800@freescale.com> (raw)
In-Reply-To: <4852A09B.100@denx.de>
Heiko Schocher wrote:
> + localbus@fff00100 {
> + compatible = "fsl,pq1-localbus";
"fsl,mpc852-localbus", "fsl,pq1-localbus", "simple-bus";
> + soc@fff00000 {
> + compatible = "fsl,mpc852", "simple-bus", "fsl,pq1-soc";
simple-bus should come last, since it's the most generic.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "soc";
> + ranges = <0 0xfff00000 0x00004000>;
> +
> + PIC: interrupt-controller@0 {
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + reg = <0 24>;
> + compatible = "fsl,pq1-pic";
"fsl,mpc852-pic", "fsl,pq1-pic";
In general, a chip-specific name should be listed first, so the driver
can easily apply workarounds if needed. See the existing 8xx device
trees for examples.
-Scott
next prev parent reply other threads:[~2008-06-13 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 0:32 [PATCH] [8xx] powerpc: Add support for the MPC852 based mgsuvd board from keymile Vitaly Bordug
2008-06-12 15:28 ` Scott Wood
2008-06-13 16:30 ` Heiko Schocher
2008-06-13 15:51 ` Scott Wood [this message]
2008-06-13 19:56 ` Heiko Schocher
2008-06-14 7:57 ` Stephen Rothwell
2008-06-14 19:02 ` Heiko Schocher
2008-06-15 0:48 ` Stephen Rothwell
2008-08-29 12:04 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4852977B.8030800@freescale.com \
--to=scottwood@freescale.com \
--cc=hs@denx.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).