linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: John Rigby <jrigby@freescale.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Scott Wood <scottwood@freescale.com>,
	linuxppc-dev@ozlabs.org, jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [Rev2] MPC5121 FEC support
Date: Tue, 17 Jun 2008 13:43:40 -0600	[thread overview]
Message-ID: <485813EC.6030602@freescale.com> (raw)
In-Reply-To: <20080617192237.GA12961@uranus.ravnborg.org>

Thanks Sam,  Scott already addressed most of your issues.  The 
background that you are likely missing and I will add to the patch 
header is that the 5121 has an FEC core with all the same registers as 
8xx except the order of the registers is scrambled.  Fortunately the old 
FEC only exists on CPM1 machines so we can use CONFIG_CPM1 to 
differentiate between the two.


>
> I we have a conversion from fec_t to struct fec
> then this is a separate patch in the normal case.
>   
I'll split the patch into a clean-up patch followed by a 5121 patch.

  parent reply	other threads:[~2008-06-17 19:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 19:08 [PATCH] [Rev2] MPC5121 FEC support John Rigby
2008-06-17 19:22 ` Sam Ravnborg
2008-06-17 19:31   ` Scott Wood
2008-06-17 19:46     ` Sam Ravnborg
2008-06-17 19:43   ` John Rigby [this message]
2008-06-17 19:57     ` Sam Ravnborg
2008-06-17 19:33 ` Scott Wood
2008-06-17 19:57   ` Sam Ravnborg
2008-06-17 20:03     ` Scott Wood
2008-06-17 21:00       ` Sam Ravnborg
2008-06-17 21:12         ` Scott Wood
2008-06-17 23:52           ` Trent Piepho
2008-06-18  5:00             ` Sam Ravnborg
2008-06-18 15:43             ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485813EC.6030602@freescale.com \
    --to=jrigby@freescale.com \
    --cc=jeff@garzik.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).