linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: select CRC32 in Kconfig
Date: Tue, 17 Jun 2008 23:25:47 -0400	[thread overview]
Message-ID: <4858803B.7020008@pobox.com> (raw)
In-Reply-To: <20080617192755.575dcad4@zod.rchland.ibm.com>

Josh Boyer wrote:
> The ibm_newemac driver requires ether_crc to be defined.  Apparently it is
> possible to generate a .config without CONFIG_CRC32 set which causes the
> following link errors if IBM_NEW_EMAC is selected:
> 
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `emac_hash_mc':
> core.c:(.text+0x2f524): undefined reference to `crc32_le'
> core.c:(.text+0x2f528): undefined reference to `bitrev32'
> make: *** [.tmp_vmlinux1] Error 1
> 
> This patch has IBM_NEW_EMAC select CRC32 so we don't hit this error.
> 
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> ---
>  drivers/net/ibm_newemac/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

applied

      reply	other threads:[~2008-06-18  3:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 23:27 [PATCH] ibm_newemac: select CRC32 in Kconfig Josh Boyer
2008-06-18  3:25 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4858803B.7020008@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).