From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, John Rigby <jrigby@freescale.com>
Subject: Re: [PATCH 5/6] MPC5121 Add PCI support
Date: Fri, 20 Jun 2008 17:17:49 -0500 [thread overview]
Message-ID: <485C2C8D.5030703@freescale.com> (raw)
In-Reply-To: <A09E5DF4-4844-41E6-B30A-C3E08BE342EB@kernel.crashing.org>
Kumar Gala wrote:
>> diff --git a/arch/powerpc/platforms/512x/pci.c
>> b/arch/powerpc/platforms/512x/pci.c
>> new file mode 100644
>> index 0000000..7ed9b34
>> --- /dev/null
>> +++ b/arch/powerpc/platforms/512x/pci.c
>> @@ -0,0 +1,84 @@
>> +/*
>> + * Copyright (C) 2008 Freescale Semiconductor, Inc. All rights reserved.
>> + *
>> + * Original copied from 83xx/pci.c:
>
> Can we not reuse the same code for 83xx/pci.c and 5121/pci? and move it
> into sysdev/fsl_pci.c? (we'd add some ifdefs for 83xx & 5121)
I assume by "ifdefs" you mean "device tree checks", right? :-)
-Scott
next prev parent reply other threads:[~2008-06-20 22:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 16:58 [PATCH 0/6] MPC5121 Updates John Rigby
[not found] ` <1213981119-1979-2-git-send-email-jrigby@freescale.com>
2008-06-20 16:58 ` [PATCH 2/6] MPC5121 clock driver John Rigby
2008-06-20 16:58 ` [PATCH 3/6] MPC5121 Add generic board support John Rigby
2008-06-20 16:58 ` [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support John Rigby
2008-06-20 16:58 ` [PATCH 5/6] MPC5121 Add PCI support John Rigby
2008-06-20 16:58 ` [PATCH 6/6] MPC5121 Hide pci bridge John Rigby
2008-06-29 5:42 ` Grant Likely
2008-06-20 22:03 ` [PATCH 5/6] MPC5121 Add PCI support Kumar Gala
2008-06-20 22:17 ` Scott Wood [this message]
2008-06-29 5:38 ` Grant Likely
2008-06-30 3:59 ` John Rigby
2008-06-29 5:36 ` [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support Grant Likely
2008-06-30 4:01 ` John Rigby
2008-06-29 5:30 ` [PATCH 3/6] MPC5121 Add generic board support Grant Likely
2008-06-21 4:39 ` [PATCH 2/6] MPC5121 clock driver Stephen Rothwell
2008-06-29 5:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485C2C8D.5030703@freescale.com \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).