linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: add of_find_next_property and of_get_aliased_index
Date: Thu, 26 Jun 2008 10:55:14 -0500	[thread overview]
Message-ID: <4863BBE2.2060107@freescale.com> (raw)
In-Reply-To: <200806261751.05379.sr@denx.de>

Stefan Roese wrote:
> On Thursday 26 June 2008, Timur Tabi wrote:
>>> The only thing a platform should ever use aliases for is if it needs
>>> to (for whatever purpose) find a specific device, that it cannot
>>> identify otherwise (via "reg", ...).  And then that platform code
>>> should look up the device by the alias, not look up the alias by the
>>> device -- there is no 1-1 mapping from device to alias!
>> Hmmm, I hadn't through about that.  I guess this patch isn't such a great
>> idea after all.  I rescind it.
> 
> Too bad. So now we're back to where we started with the discussion 
> about "cell-index" vs. "index" vs. no index on I2C device nodes. :-(

Well, there's a lot of disagreement on this subject.  Not only do we not agree
on a method of enumerating devices, a lot of people have a problem with the
concept of enumerating them in the first place!

This whole thing started with a problem I had in ASoC V2: identifying an I2C
device by name and number.  Scott W. pointed out that all I need in my "fabric
driver" is a pointer to the i2c_adapter structure that the I2C driver was using.
 If we create a link from the I2C device node to its matching i2c_adapter
structure, then I won't care what the adapter/bus number is.  Unfortunately, it
appears the current I2C code in fsl_soc.c can't handle that, but of_i2c.c can.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2008-06-26 15:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 20:05 [PATCH] powerpc: add of_find_next_property and of_get_aliased_index Timur Tabi
2008-06-25 20:22 ` Segher Boessenkool
2008-06-25 20:27   ` Timur Tabi
2008-06-25 23:35     ` Segher Boessenkool
2008-06-26 15:12       ` Timur Tabi
2008-06-26 15:51         ` Stefan Roese
2008-06-26 15:55           ` Timur Tabi [this message]
2008-06-26 18:27             ` [PATCH] powerpc: add of_find_next_property andof_get_aliased_index Sean MacLennan
2008-06-26 18:29               ` Timur Tabi
2008-06-26 18:41               ` Stefan Roese
2008-06-27  1:30                 ` David Gibson
2008-07-03 13:33                 ` Josh Boyer
2008-07-03 13:43                   ` Stefan Roese
2008-06-25 23:51 ` [PATCH] powerpc: add of_find_next_property and of_get_aliased_index Josh Boyer
2008-06-26 10:57 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4863BBE2.2060107@freescale.com \
    --to=timur@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).