From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
aik@ozlabs.ru, Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
drt@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
david@gibson.dropbear.id.au
Subject: Re: [PATCH] powerpc/pseries/vio: Fix iommu_table use-after-free refcount warning
Date: Wed, 29 Jan 2020 16:17:40 +1100 (AEDT) [thread overview]
Message-ID: <486sF12qt1z9sSD@ozlabs.org> (raw)
In-Reply-To: <1579558202-26052-1-git-send-email-tyreld@linux.ibm.com>
On Mon, 2020-01-20 at 22:10:02 UTC, Tyrel Datwyler wrote:
> From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
>
> Commit e5afdf9dd515 ("powerpc/vfio_spapr_tce: Add reference counting to
> iommu_table") missed an iommu_table allocation in the pseries vio code.
> The iommu_table is allocated with kzalloc and as a result the associated
> kref gets a value of zero. This has the side effect that during a DLPAR
> remove of the associated virtual IOA the iommu_tce_table_put() triggers
> a use-after-free underflow warning.
>
> Call Trace:
> [c0000002879e39f0] [c00000000071ecb4] refcount_warn_saturate+0x184/0x190
> (unreliable)
> [c0000002879e3a50] [c0000000000500ac] iommu_tce_table_put+0x9c/0xb0
> [c0000002879e3a70] [c0000000000f54e4] vio_dev_release+0x34/0x70
> [c0000002879e3aa0] [c00000000087cfa4] device_release+0x54/0xf0
> [c0000002879e3b10] [c000000000d64c84] kobject_cleanup+0xa4/0x240
> [c0000002879e3b90] [c00000000087d358] put_device+0x28/0x40
> [c0000002879e3bb0] [c0000000007a328c] dlpar_remove_slot+0x15c/0x250
> [c0000002879e3c50] [c0000000007a348c] remove_slot_store+0xac/0xf0
> [c0000002879e3cd0] [c000000000d64220] kobj_attr_store+0x30/0x60
> [c0000002879e3cf0] [c0000000004ff13c] sysfs_kf_write+0x6c/0xa0
> [c0000002879e3d10] [c0000000004fde4c] kernfs_fop_write+0x18c/0x260
> [c0000002879e3d60] [c000000000410f3c] __vfs_write+0x3c/0x70
> [c0000002879e3d80] [c000000000415408] vfs_write+0xc8/0x250
> [c0000002879e3dd0] [c0000000004157dc] ksys_write+0x7c/0x120
> [c0000002879e3e20] [c00000000000b278] system_call+0x5c/0x68
>
> Further, since the refcount was always zero the iommu_tce_table_put()
> fails to call the iommu_table release function resulting in a leak.
>
> Fix this issue be initilizing the iommu_table kref immediately after
> allocation.
>
> Fixes: e5afdf9dd515 ("powerpc/vfio_spapr_tce: Add reference counting to iommu_table")
> Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/aff8c8242bc638ba57247ae1ec5f272ac3ed3b92
cheers
prev parent reply other threads:[~2020-01-29 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 22:10 [PATCH] powerpc/pseries/vio: Fix iommu_table use-after-free refcount warning Tyrel Datwyler
2020-01-21 3:45 ` Alexey Kardashevskiy
2020-01-29 5:17 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486sF12qt1z9sSD@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=drt@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tyreld@linux.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).