linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Brian King <brking@linux.vnet.ibm.com>
To: Robert Jennings <rcj@linux.vnet.ibm.com>
Cc: paulus@samba.org, David Darrington <ddarring@linux.vnet.ibm.com>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: correct CMO feature flag enablement
Date: Tue, 15 Jul 2008 16:39:14 -0500	[thread overview]
Message-ID: <487D1902.20609@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080715212008.GA25230@linux.vnet.ibm.com>

Acked by: Brian King <brking@linux.vnet.ibm.com>

Robert Jennings wrote:
> Correct string conversion for rtas value being read for CMO configuration.
> A value of -1 in the string indicates that CMO is not enabled and we
> had used simple_strtoul rather than simple_strtol which caused problems.
> 
> Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
> 
> ---
> 
> This patch applies on top of the CMO patchset sent to the list.
> 
> ---
>  arch/powerpc/platforms/pseries/setup.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: b/arch/powerpc/platforms/pseries/setup.c
> ===================================================================
> --- a/arch/powerpc/platforms/pseries/setup.c
> +++ b/arch/powerpc/platforms/pseries/setup.c
> @@ -366,9 +366,9 @@ void pSeries_cmo_feature_init(void)
>  			}
> 
>  			if (0 == strcmp(key, "PrPSP"))
> -				PrPSP = simple_strtoul(value, NULL, 10);
> +				PrPSP = simple_strtol(value, NULL, 10);
>  			else if (0 == strcmp(key, "SecPSP"))
> -				SecPSP = simple_strtoul(value, NULL, 10);
> +				SecPSP = simple_strtol(value, NULL, 10);
>  			value = key = ptr + 1;
>  		}
>  		ptr++;


-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center

      reply	other threads:[~2008-07-15 21:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 21:20 [PATCH] powerpc: correct CMO feature flag enablement Robert Jennings
2008-07-15 21:39 ` Brian King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487D1902.20609@linux.vnet.ibm.com \
    --to=brking@linux.vnet.ibm.com \
    --cc=ddarring@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=rcj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).