* [PATCH] powerpc: correct CMO feature flag enablement
@ 2008-07-15 21:20 Robert Jennings
2008-07-15 21:39 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Robert Jennings @ 2008-07-15 21:20 UTC (permalink / raw)
To: Benjamin Herrenschmidt, paulus, linuxppc-dev, Brian King,
Nathan Fontenot, David Darrington
Correct string conversion for rtas value being read for CMO configuration.
A value of -1 in the string indicates that CMO is not enabled and we
had used simple_strtoul rather than simple_strtol which caused problems.
Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
---
This patch applies on top of the CMO patchset sent to the list.
---
arch/powerpc/platforms/pseries/setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/arch/powerpc/platforms/pseries/setup.c
===================================================================
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -366,9 +366,9 @@ void pSeries_cmo_feature_init(void)
}
if (0 == strcmp(key, "PrPSP"))
- PrPSP = simple_strtoul(value, NULL, 10);
+ PrPSP = simple_strtol(value, NULL, 10);
else if (0 == strcmp(key, "SecPSP"))
- SecPSP = simple_strtoul(value, NULL, 10);
+ SecPSP = simple_strtol(value, NULL, 10);
value = key = ptr + 1;
}
ptr++;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: correct CMO feature flag enablement
2008-07-15 21:20 [PATCH] powerpc: correct CMO feature flag enablement Robert Jennings
@ 2008-07-15 21:39 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2008-07-15 21:39 UTC (permalink / raw)
To: Robert Jennings; +Cc: paulus, David Darrington, linuxppc-dev
Acked by: Brian King <brking@linux.vnet.ibm.com>
Robert Jennings wrote:
> Correct string conversion for rtas value being read for CMO configuration.
> A value of -1 in the string indicates that CMO is not enabled and we
> had used simple_strtoul rather than simple_strtol which caused problems.
>
> Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
>
> ---
>
> This patch applies on top of the CMO patchset sent to the list.
>
> ---
> arch/powerpc/platforms/pseries/setup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/arch/powerpc/platforms/pseries/setup.c
> ===================================================================
> --- a/arch/powerpc/platforms/pseries/setup.c
> +++ b/arch/powerpc/platforms/pseries/setup.c
> @@ -366,9 +366,9 @@ void pSeries_cmo_feature_init(void)
> }
>
> if (0 == strcmp(key, "PrPSP"))
> - PrPSP = simple_strtoul(value, NULL, 10);
> + PrPSP = simple_strtol(value, NULL, 10);
> else if (0 == strcmp(key, "SecPSP"))
> - SecPSP = simple_strtoul(value, NULL, 10);
> + SecPSP = simple_strtol(value, NULL, 10);
> value = key = ptr + 1;
> }
> ptr++;
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-15 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-15 21:20 [PATCH] powerpc: correct CMO feature flag enablement Robert Jennings
2008-07-15 21:39 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).