linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Linuxppc-dev@ozlabs.org, lm-sensors@lm-sensors.org,
	Detlev Zundel <dzu@denx.de>,
	Alan Clucas <alanc@pipstechnology.co.uk>
Subject: Re: [PATCH] Support for DS75 thermal sensor
Date: Thu, 17 Jul 2008 09:31:24 +0200	[thread overview]
Message-ID: <487EF54C.5020007@grandegger.com> (raw)
In-Reply-To: <20080716162942.6fcb526d@hyperion.delvare>

Jean Delvare wrote:
> On Wed, 16 Jul 2008 10:18:26 -0400, Jon Smirl wrote:
>> On 7/16/08, Grant Likely <grant.likely@secretlab.ca> wrote:
>>> On Wed, Jul 16, 2008 at 12:10:59PM +0200, Jean Delvare wrote:
>>>  > On Wed, 16 Jul 2008 11:50:15 +0200, Wolfgang Grandegger wrote:
>>>  > > Jean Delvare wrote:
>>>  > >
>>>
>>>>> Yep, as probing might not be acceptable in some cases, I makes sense to
>>>  > > add a property to suppress probing:
>>>  >
>>>  > It'd rather make no-probing the default if possible. My understanding
>>>  > is that all systems using i2c-mpc should have proper platform data.
>>>
>>>
>>> Total ACK.  From my perspective, probing should be off by default because the
>>>  typical use case in powerpc land is to trust data in the device tree.  Add the
>>>  property to turn on probing, not to turn it off.  Also, you'll need to
>>>  document the semantics of such a property.  ie. what exactly does it
>>>  mean when the probing property is present and the spi bus node has child
>>>  nodes?
>> I've found this thread now. Why can't we totally remove probing from
>> i2c-mpc? These are embedded systems, not open boxes like a PC. If a
>> i2c client hasn't been converted to the new model yet, convert it
>> before deploying with the new i2c-mpc driver.  It's not very hard to
>> convert the client drivers.
> 
> I tend to agree. And the number of unconverted drivers is getting very
> low these days. Only 2 RTC drivers are left, and by the end of the day,
> almost all hwmon drivers will be converted as well.

Thinking more about it I also prefer removing the I2C_CLASS_HWMON flag 
completely. It just affects HWMON devices anyhow and if there is still 
an old style driver around, it should be converted.

Wolfgang.

  reply	other threads:[~2008-07-17  7:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <487331DC.2020601@grandegger.com>
     [not found] ` <20080708115319.111226e6@hyperion.delvare>
     [not found]   ` <4873670C.6080204@grandegger.com>
     [not found]     ` <20080708152935.7457bc90@hyperion.delvare>
     [not found]       ` <487754DA.1060207@grandegger.com>
     [not found]         ` <20080711145613.14380360@hyperion.delvare>
2008-07-16  9:12           ` [lm-sensors] [PATCH] Support for DS75 thermal sensor Wolfgang Grandegger
2008-07-16  9:33             ` Jean Delvare
2008-07-16  9:50               ` Wolfgang Grandegger
2008-07-16 10:10                 ` Jean Delvare
2008-07-16 10:23                   ` Wolfgang Grandegger
2008-07-16 14:08                   ` Grant Likely
2008-07-16 14:18                     ` Jon Smirl
2008-07-16 14:29                       ` Jean Delvare
2008-07-17  7:31                         ` Wolfgang Grandegger [this message]
2008-07-17  7:33                           ` Grant Likely
2008-07-17 10:39                             ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487EF54C.5020007@grandegger.com \
    --to=wg@grandegger.com \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=alanc@pipstechnology.co.uk \
    --cc=dzu@denx.de \
    --cc=khali@linux-fr.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).