From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.scram.de (mail0.scram.de [78.47.204.202]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.scram.de", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7C6B0DE0AF for ; Sat, 19 Jul 2008 01:30:53 +1000 (EST) Message-ID: <4880B730.8050801@scram.de> Date: Fri, 18 Jul 2008 17:30:56 +0200 From: Jochen Friedrich MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCHv3 1/2] [POWERPC] CPM2: Implement GPIO LIB API on CPM2 Freescale SoC. References: <4808D75B.9000002@scram.de> <200806131715.59345.laurentp@cse-semaphore.com> <48593E56.70708@scram.de> <200806181908.41525.laurentp@cse-semaphore.com> <8D84340F-427C-403B-8121-481642478B8C@kernel.crashing.org> In-Reply-To: <8D84340F-427C-403B-8121-481642478B8C@kernel.crashing.org> Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev list , Scott Wood List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Kumar, > On Jun 18, 2008, at 12:08 PM, Laurent Pinchart wrote: > >> +#if defined(CONFIG_CPM2) || defined(CONFIG_8xx_GPIO) >> + >> +struct cpm2_ioports { >> + u32 dir, par, sor, odr, dat; >> + u32 res[3]; >> +}; >> + > > is this really common for both CPM2 and 8xx? if so why the name? It is common to CPM2 and Port E of CPM1. Thanks, Jochen