From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Yue Haibing <yuehaibing@huawei.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
mahesh@linux.vnet.ibm.com, npiggin@gmail.com,
ganeshgr@linux.ibm.com, anton@samba.org, ruscur@russell.cc
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
Date: Thu, 25 Apr 2019 15:17:49 -0700 [thread overview]
Message-ID: <48912eeb-1c5b-f401-fd12-ed568bc371ea@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190424021739.20916-1-yuehaibing@huawei.com>
On 04/23/2019 07:17 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> v2: fix compile issue by 'event_modifier'-->'modifier'
> ---
> arch/powerpc/platforms/pseries/ras.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index c97d153..744604d 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
> break;
>
> case EPOW_SYSTEM_SHUTDOWN:
> - handle_system_shutdown(epow_log->event_modifier);
> + handle_system_shutdown(modifier);
> break;
>
> case EPOW_SYSTEM_HALT:
>
next prev parent reply other threads:[~2019-04-25 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:35 [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog() Yue Haibing
2019-04-24 1:29 ` Russell Currey
2019-04-24 1:48 ` YueHaibing
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
2019-04-25 22:17 ` Tyrel Datwyler [this message]
2019-05-30 15:00 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48912eeb-1c5b-f401-fd12-ed568bc371ea@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=ganeshgr@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox