From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <48922715.2000304@freescale.com> Date: Thu, 31 Jul 2008 15:56:53 -0500 From: Timur Tabi MIME-Version: 1.0 To: Jon Smirl Subject: Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT References: <20080731182810.GB29097@secretlab.ca> <48921187.1090101@grandegger.com> <48921179.1080403@freescale.com> <48921888.3020900@grandegger.com> <48921954.4020103@freescale.com> <48921DED.6010403@grandegger.com> <9e4733910807311332q611b43b3y26f64b5269ccb657@mail.gmail.com> <48922273.6070801@freescale.com> <20080731204838.GA29834@secretlab.ca> <9e4733910807311355q3394b4bfg66c37055384451f7@mail.gmail.com> In-Reply-To: <9e4733910807311355q3394b4bfg66c37055384451f7@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: Scott Wood , Linux I2C , Linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Jon Smirl wrote: > Isn't there a single global divider that generates all the i2c source > clocks? You don't want to copy a global value into each i2c node. Why not? There are only two I2C devices, and it's theoretically possible for them to have different input clock frequencies. Keeping it in the I2C node allows the I2C driver to reference a property directly in the node that its probing. > Aren't we talking about the /2 or /3 or /1 divider that appears to be > randomly implemented on various members of the mpc8xxx family? Yes. -- Timur Tabi Linux kernel developer at Freescale