From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <48922BE4.5030507@freescale.com> Date: Thu, 31 Jul 2008 16:17:24 -0500 From: Timur Tabi MIME-Version: 1.0 To: Wolfgang Grandegger Subject: Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT References: <20080731182810.GB29097@secretlab.ca> <48921888.3020900@grandegger.com> <48921954.4020103@freescale.com> <48921DED.6010403@grandegger.com> <9e4733910807311332q611b43b3y26f64b5269ccb657@mail.gmail.com> <48922273.6070801@freescale.com> <20080731204838.GA29834@secretlab.ca> <9e4733910807311355q3394b4bfg66c37055384451f7@mail.gmail.com> <48922715.2000304@freescale.com> <9e4733910807311403o63c37366ldae30e873f33a21e@mail.gmail.com> <48922B40.3010808@grandegger.com> In-Reply-To: <48922B40.3010808@grandegger.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: Scott Wood , Linux I2C , Linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Wolfgang Grandegger wrote: > U-Boot does not (yet) use the FDT and it has therefore to use that ugly > code to derive the I2C input clock frequency. I think its completely > legal to put that hardware specific information into the FDT and get rid > of such code. Huh? U-Boot initializes several fields and creates several properties in the FDT today, so what's wrong with adding another one? The clock frequencies have always been calculated by U-Boot, because putting them in the device tree is a bad idea. -- Timur Tabi Linux kernel developer at Freescale