* I2C probe not happening
@ 2008-08-21 16:03 Steven A. Falco
0 siblings, 0 replies; only message in thread
From: Steven A. Falco @ 2008-08-21 16:03 UTC (permalink / raw)
To: linuxppc-dev
I'm using DENX-2.6.26, and I've enabled the I2C_IBM_IIC on a Sequoia board,
but I don't see any probes happening.
It looks like of_register_i2c_devices is never being called. According to
cscope, it would be called in i2c-ibm_of.c, but that file is not part of
the build.
i2c-ibm_of.c would be compiled if CONFIG_I2C_IBM_OF was selected, but there
is no place in the Kconfig files that I2C_IBM_OF is mentioned. So, I added
it like so:
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index e9f88fe..a221b15 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -247,9 +247,16 @@ config I2C_PIIX4
This driver can also be built as a module. If so, the module
will be called i2c-piix4.
+config I2C_IBM_OF
+ tristate "IBM PPC 4xx open-firmware driver"
+ depends on 4xx
+ help
+ Use openfirmware driver mechanism.
+
config I2C_IBM_IIC
tristate "IBM PPC 4xx on-chip I2C interface"
depends on 4xx
+ select I2C_IBM_OF
help
Say Y here if you want to use IIC peripheral found on
embedded IBM PPC 4xx based systems.
Also, I noticed that i2c-ibm_of.c doesn't have an entry for the 440EPx, so
I added one:
diff --git a/drivers/i2c/busses/i2c-ibm_of.c b/drivers/i2c/busses/i2c-ibm_of.c
index 08440ab..df35686 100644
--- a/drivers/i2c/busses/i2c-ibm_of.c
+++ b/drivers/i2c/busses/i2c-ibm_of.c
@@ -906,6 +906,7 @@ static const struct of_device_id ibm_iic_match[] = {
{ .compatible = "ibm,iic-405ex", },
{ .compatible = "ibm,iic-405exr", },
{ .compatible = "ibm,iic-405gp", },
+ { .compatible = "ibm,iic-440epx", },
{ .compatible = "ibm,iic-440gp", },
{ .compatible = "ibm,iic-440gpx", },
{ .compatible = "ibm,iic-440grx", },
However, the file does not compile. I get:
linux-2.6-denx/drivers/i2c/busses/i2c-ibm_of.c:702:
error: 'struct i2c_board_info' has no member named 'driver_name'
make[4]: *** [drivers/i2c/busses/i2c-ibm_of.o] Error 1
So perhaps it should not be part of the build. But in that case, I see
no way for the probes to run.
I must be missing something - hints gratefully accepted.
Steve
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-21 16:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-21 16:03 I2C probe not happening Steven A. Falco
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).