From: Ilya Yanok <yanok@emcraft.com>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, sr@denx.de, wd@denx.de
Subject: Re: [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size
Date: Mon, 01 Sep 2008 11:31:58 +0400 [thread overview]
Message-ID: <48BB9A6E.2000502@emcraft.com> (raw)
In-Reply-To: <1220228340.13162.401.camel@pasglop>
Benjamin Herrenschmidt wrote:
>>> 1. total_memory should be phys_addr_t not unsigned long
>>> 2. is_power_of_2() works with u32 so I just inlined (size & (size-1)) != 0
>>> instead.
>>> Also this patch fixes default initialization: res->end should be 0x7fffffff
>>> not 0x80000000.
>>>
>>> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>>>
>> Ben, any comments here? Looks right to me.
>>
>
> Just one minor comment... The patch should do what I failed to do
> before, which is to move total_memory declaration to a header :-)
>
Hm... looks like we already have this declaration in
arch/powerpc/mm/mmu_decl.h... I'll send modified patch soon.
Regards, Ilya.
next prev parent reply other threads:[~2008-09-01 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 7:43 [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size Ilya Yanok
2008-08-28 13:28 ` Josh Boyer
2008-08-28 14:18 ` Stefan Roese
2008-09-01 0:19 ` Benjamin Herrenschmidt
2008-09-01 7:31 ` Ilya Yanok [this message]
2008-09-01 7:53 ` [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size (updated) Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BB9A6E.2000502@emcraft.com \
--to=yanok@emcraft.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).