* [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE
@ 2008-08-30 20:48 roel kluin
2008-09-01 0:30 ` Benjamin Herrenschmidt
2008-09-03 14:08 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: roel kluin @ 2008-08-30 20:48 UTC (permalink / raw)
To: david, benh; +Cc: linuxppc-dev, linux-kernel
MAL[12]_IER_EVENTS definitions have MAL_IER_OTE twice
but lack MAL_IER_DE
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/net/ibm_newemac/mal.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ibm_newemac/mal.h b/drivers/net/ibm_newemac/mal.h
index eaa7262..717dc38 100644
--- a/drivers/net/ibm_newemac/mal.h
+++ b/drivers/net/ibm_newemac/mal.h
@@ -102,7 +102,7 @@
/* MAL V1 IER bits */
#define MAL1_IER_NWE 0x00000008
#define MAL1_IER_SOC_EVENTS MAL1_IER_NWE
-#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_OTE | \
+#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_DE | \
MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
/* MAL V2 IER bits */
@@ -110,7 +110,7 @@
#define MAL2_IER_PRE 0x00000040
#define MAL2_IER_PWE 0x00000020
#define MAL2_IER_SOC_EVENTS (MAL2_IER_PT | MAL2_IER_PRE | MAL2_IER_PWE)
-#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_OTE | \
+#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_DE | \
MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE
2008-08-30 20:48 [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE roel kluin
@ 2008-09-01 0:30 ` Benjamin Herrenschmidt
2008-09-03 14:08 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-09-01 0:30 UTC (permalink / raw)
To: roel kluin; +Cc: linuxppc-dev, linux-kernel, david
On Sat, 2008-08-30 at 22:48 +0200, roel kluin wrote:
> MAL[12]_IER_EVENTS definitions have MAL_IER_OTE twice
> but lack MAL_IER_DE
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Thanks.
> ---
> drivers/net/ibm_newemac/mal.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ibm_newemac/mal.h b/drivers/net/ibm_newemac/mal.h
> index eaa7262..717dc38 100644
> --- a/drivers/net/ibm_newemac/mal.h
> +++ b/drivers/net/ibm_newemac/mal.h
> @@ -102,7 +102,7 @@
> /* MAL V1 IER bits */
> #define MAL1_IER_NWE 0x00000008
> #define MAL1_IER_SOC_EVENTS MAL1_IER_NWE
> -#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
>
> /* MAL V2 IER bits */
> @@ -110,7 +110,7 @@
> #define MAL2_IER_PRE 0x00000040
> #define MAL2_IER_PWE 0x00000020
> #define MAL2_IER_SOC_EVENTS (MAL2_IER_PT | MAL2_IER_PRE | MAL2_IER_PWE)
> -#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE
2008-08-30 20:48 [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE roel kluin
2008-09-01 0:30 ` Benjamin Herrenschmidt
@ 2008-09-03 14:08 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-09-03 14:08 UTC (permalink / raw)
To: roel kluin; +Cc: linuxppc-dev, linux-kernel, david
roel kluin wrote:
> MAL[12]_IER_EVENTS definitions have MAL_IER_OTE twice
> but lack MAL_IER_DE
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/net/ibm_newemac/mal.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ibm_newemac/mal.h b/drivers/net/ibm_newemac/mal.h
> index eaa7262..717dc38 100644
> --- a/drivers/net/ibm_newemac/mal.h
> +++ b/drivers/net/ibm_newemac/mal.h
> @@ -102,7 +102,7 @@
> /* MAL V1 IER bits */
> #define MAL1_IER_NWE 0x00000008
> #define MAL1_IER_SOC_EVENTS MAL1_IER_NWE
> -#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL1_IER_EVENTS (MAL1_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
>
> /* MAL V2 IER bits */
> @@ -110,7 +110,7 @@
> #define MAL2_IER_PRE 0x00000040
> #define MAL2_IER_PWE 0x00000020
> #define MAL2_IER_SOC_EVENTS (MAL2_IER_PT | MAL2_IER_PRE | MAL2_IER_PWE)
> -#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_OTE | \
> +#define MAL2_IER_EVENTS (MAL2_IER_SOC_EVENTS | MAL_IER_DE | \
> MAL_IER_OTE | MAL_IER_OE | MAL_IER_PE)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-03 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-30 20:48 [PATCH] ibm_newemac: MAL[12]_IER_EVENTS definition: 2x *_OTE -> *_DE roel kluin
2008-09-01 0:30 ` Benjamin Herrenschmidt
2008-09-03 14:08 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).