linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [FIX] fs_enet: Using mii-bitbang as module
Date: Thu, 04 Sep 2008 08:01:38 +0200	[thread overview]
Message-ID: <48BF79C2.6050902@denx.de> (raw)

Hello Vitaly,

I tried to use the mii-bitbang driver (drivers/net/fs_enet/mii-bitbang.c)
as a module and got the following error, when inserting it with insmod:

~ # insmod fs_enet
eth0: fs_enet: a6:07:11:7f:de:26
~ # insmod mii-bitbang
mii_bitbang: module license 'unspecified' taints kernel.
mii_bitbang: Unknown symbol of_address_to_resource
mii_bitbang: Unknown symbol of_irq_to_resource
insmod: cannot insert '/lib/modules/2.6.27-rc5-01144-g967b424-dirty/kernel/drivers/net/fs_enet/mii-bitbang.ko': Unknown symbol in module (-1): No such file or directory
~ #

Following patch solves this. Maybe you add the other MODULE_ macros too?

Signed-off-by: Heiko Schocher <hs@denx.de>
---
 drivers/net/fs_enet/mii-bitbang.c                  |    2 +
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c
index be4b72f..863ceed 100644
--- a/drivers/net/fs_enet/mii-bitbang.c
+++ b/drivers/net/fs_enet/mii-bitbang.c
@@ -26,6 +26,8 @@

 #include "fs_enet.h"

+MODULE_LICENSE("GPL");
+
 struct bb_info {
 	struct mdiobb_ctrl ctrl;
 	__be32 __iomem *dir;
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

             reply	other threads:[~2008-09-04  6:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-04  6:01 Heiko Schocher [this message]
2008-09-04 18:40 ` [FIX] fs_enet: Using mii-bitbang as module Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BF79C2.6050902@denx.de \
    --to=hs@denx.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=vitb@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).