Not probing devices on PowerPC MPC8247 and kernel 2.6.26

Not probing devices on PowerPC MPC8247 and kernel 2.6.26

[Chris Skepper]

Hi All,

I have an MPC8247 based board.  I can get the SMC1 console working, but 
the other SCCx serial ports and the FCC1 ethernet doesn't work.

It appears that a part of the problem is that the probe methods are not 
called.  The "match" table stuff all looks fine and the serial ports and 
ethernet are defined in the .dts file. The module init function is called, 
but the probe methods are not reached. It seems driver_register gets 
called, so why doesn't something call probe?

Is there likely to be some problem with the bus setup?

Cheers,

Chris.

Re: Not probing devices on PowerPC MPC8247 and kernel 2.6.26

[Marco Stornelli]

Hi Chris,

probably there's some mismatch between the device (for example some 
information in dts) and the driver. The match function scan for a driver 
for those devices but the values compared don't match the values of the 
drivers.

Regards.

Chris Skepper ha scritto:
> Hi All,
>
> I have an MPC8247 based board. I can get the SMC1 console working, but 
> the other SCCx serial ports and the FCC1 ethernet doesn't work.
>
> It appears that a part of the problem is that the probe methods are 
> not called. The "match" table stuff all looks fine and the serial 
> ports and ethernet are defined in the .dts file. The module init 
> function is called, but the probe methods are not reached. It seems 
> driver_register gets called, so why doesn't something call probe?
>
> Is there likely to be some problem with the bus setup?
>
> Cheers,
>
> Chris.
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>

-- 
Marco Stornelli
Embedded Software Engineer
CoRiTeL - Consorzio di Ricerca sulle Telecomunicazioni
http://www.coritel.it

marco.stornelli@coritel.it
+39 06 72582838

Re: Not probing devices on PowerPC MPC8247 and kernel 2.6.26

[Chris Skepper]

> Chris Skepper ha scritto:
>> I have an MPC8247 based board. I can get the SMC1 console working, but the 
>> other SCCx serial ports and the FCC1 ethernet doesn't work.
>> 
>> It appears that a part of the problem is that the probe methods are not 
>> called. The "match" table stuff all looks fine and the serial ports and 
>> ethernet are defined in the .dts file. The module init function is called, 
>> but the probe methods are not reached. It seems driver_register gets 
>> called, so why doesn't something call probe?
>> 
>> Is there likely to be some problem with the bus setup?

On Wed, 10 Sep 2008, Marco Stornelli wrote:
> probably there's some mismatch between the device (for example some 
> information in dts) and the driver. The match function scan for a driver for 
> those devices but the values compared don't match the values of the drivers.

Hi Marco,

Thanks.  But I think the "compatible" properties in the DTS are set 
correctly.  I have "fsl,cpm2-fcc-enet" for the ethernet and 
"fsl,cpm2-scc-uart" which seems to be what's in the match_table.

Is there something else I should check?

Cheers,

Chris.

Re: Not probing devices on PowerPC MPC8247 and kernel 2.6.26

[Scott Wood]

Chris Skepper wrote:
> Hi All,
> 
> I have an MPC8247 based board.  I can get the SMC1 console working, but 
> the other SCCx serial ports and the FCC1 ethernet doesn't work.
> 
> It appears that a part of the problem is that the probe methods are not 
> called.  The "match" table stuff all looks fine and the serial ports and 
> ethernet are defined in the .dts file. The module init function is 
> called, but the probe methods are not reached. It seems driver_register 
> gets called, so why doesn't something call probe?
> 
> Is there likely to be some problem with the bus setup?

Are you calling of_platform_bus_probe() from your platform code, and do 
the soc and cpm nodes match the bus list (I recommend using compatible = 
"simple-bus")?

-Scott

Re: Not probing devices on PowerPC MPC8247 and kernel 2.6.26

[Chris Skepper]

>> I have an MPC8247 based board.  I can get the SMC1 console working, but the 
>> other SCCx serial ports and the FCC1 ethernet doesn't work.
>> 
>> It appears that a part of the problem is that the probe methods are not 
>> called.  The "match" table stuff all looks fine and the serial ports and 
>> ethernet are defined in the .dts file. The module init function is called, 
>> but the probe methods are not reached. It seems driver_register gets 
>> called, so why doesn't something call probe?
>> 
>> Is there likely to be some problem with the bus setup?
>
> Are you calling of_platform_bus_probe() from your platform code, and do the 
> soc and cpm nodes match the bus list (I recommend using compatible = 
> "simple-bus")?
>
> -Scott


Hi Scott,

I added the simple-bus to the soc and cpm nodes and it started working 
just before your email arrived, but it's good to know I did the right 
thing.

Thanks for all your help, I've now got my board working very happily with 
Linux 2.6.26 and arch=powerpc.  In the end it was pretty much all in the 
dts file, but I don't think I'd have got there without your hints.

Cheers,

Chris.