From: Jeff Garzik <jeff@garzik.org>
To: Hannes Hering <hannes.hering@gmx.de>
Cc: themann@de.ibm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, raisch@de.ibm.com,
ossrosch@linux.vnet.ibm.com, linuxppc-dev@ozlabs.org,
ossthema@de.ibm.com, osstklei@de.ibm.com
Subject: Re: [PATCH 1/2] ehea: Fix DLPAR memory handling
Date: Sat, 13 Sep 2008 15:55:47 -0400 [thread overview]
Message-ID: <48CC1AC3.7090406@garzik.org> (raw)
In-Reply-To: <200809051636.26545.hannes.hering@gmx.de>
Hannes Hering wrote:
> The ehea busmap must be allocated only once in the first of many calls of the
> ehea_create_busmap_callback.
>
> Signed-off-by: Hannes Hering <hering2@de.ibm.com>
> ---
>
> diff -Nurp -X dontdiff linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c patched_kernel/drivers/net/ehea/ehea_qmr.c
> --- linux-2.6.27-rc5/drivers/net/ehea/ehea_qmr.c 2008-08-29 00:52:02.000000000 +0200
> +++ patched_kernel/drivers/net/ehea/ehea_qmr.c 2008-09-05 15:31:30.000000000 +0200
> @@ -595,7 +595,8 @@ static int ehea_create_busmap_callback(u
> end_section = start_section + ((nr_pages * PAGE_SIZE) / EHEA_SECTSIZE);
> mr_len = *(unsigned long *)arg;
>
> - ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
> + if (!ehea_bmap)
> + ehea_bmap = kzalloc(sizeof(struct ehea_bmap), GFP_KERNEL);
> if (!ehea_bmap)
> return -ENOMEM;
applied
prev parent reply other threads:[~2008-09-13 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 14:36 [PATCH 1/2] ehea: Fix DLPAR memory handling Hannes Hering
2008-09-13 19:55 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CC1AC3.7090406@garzik.org \
--to=jeff@garzik.org \
--cc=hannes.hering@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=ossrosch@linux.vnet.ibm.com \
--cc=ossthema@de.ibm.com \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).