From: Joel Schopp <jschopp@austin.ibm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org, Thomas Gleixner <tglx@linutronix.de>,
bugme-daemon@bugzilla.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [Bugme-new] [Bug 11629] New: quad G5 fails to shut down
Date: Fri, 26 Sep 2008 14:17:26 -0500 [thread overview]
Message-ID: <48DD3546.3030109@austin.ibm.com> (raw)
In-Reply-To: <1222332986.10563.35.camel@johannes.berg>
> From: Johannes Berg <johannes@sipsolutions.net>
> Subject: powerpc: fix shutdown
>
> I tracked down the shutdown regression to CPUs not dying
> when being shut down during power-off. This turns out to
> be due to the system_state being SYSTEM_POWER_OFF, which
> this code doesn't take as a valid state for shutting off
> CPUs in.
>
> This has never made sense to me, but when I added hotplug
> code to implement hibernate I only "made it work" and did
> not question the need to check the system_state. Thomas
> Gleixner helped me dig, but the only thing we found is
> that it was added with the original commit that added CPU
> hotplug support.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Joel Schopp <jschopp@austin.ibm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
Tested this patch on a Power6 partition with cpu hotplug online/offline
and some shutdown and reboot cycles. Didn't see any ill effects.
Acked-by: Joel Schopp <jschopp@austin.ibm.com>
prev parent reply other threads:[~2008-09-26 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-11629-10286@http.bugzilla.kernel.org/>
2008-09-23 21:30 ` [Bugme-new] [Bug 11629] New: quad G5 fails to shut down Andrew Morton
2008-09-23 21:50 ` Johannes Berg
2008-09-23 22:45 ` Johannes Berg
2008-09-23 23:10 ` Johannes Berg
2008-09-24 10:07 ` Johannes Berg
2008-09-25 8:56 ` Johannes Berg
2008-09-26 19:17 ` Joel Schopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DD3546.3030109@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).