linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: embedded <embedded@akb.net>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: FCC1 failing on large packet PINGS, while FCC2 is successful
Date: Tue, 30 Sep 2008 11:49:33 -0500	[thread overview]
Message-ID: <48E2589D.8090406@freescale.com> (raw)
In-Reply-To: <bfa0697f0809300946m3509f8b6r9720f38dde3e2ce1@mail.gmail.com>

embedded wrote:
> Actually, it may have been a simple fix.  Looking at the clocks. We
> noticed something a little awry;  Just rechecking the RM and the code
> we found that within ep8248.c, the clock setup code had the RX and TX
> clocks flipped.
> 
> FCC1 RX CLK should be Clock 10
> FCC1 TX CLK should be Clock 11

D'oh!  Thanks for finding that.

> in: arch/powerpc/platforms/82xx/ep8248.c
> static void __init init_ioports(void)
> 
> -	cpm2_clk_setup(CPM_CLK_FCC1, CPM_CLK11, CPM_CLK_RX);
> -	cpm2_clk_setup(CPM_CLK_FCC1, CPM_CLK10, CPM_CLK_TX);
> 
> +	cpm2_clk_setup(CPM_CLK_FCC1, CPM_CLK10, CPM_CLK_RX);
> +	cpm2_clk_setup(CPM_CLK_FCC1, CPM_CLK11, CPM_CLK_TX);

Acked-by: Scott Wood <scottwood@freescale.com>

Post to linuxppc-dev@ozlabs.org and galak@kernel.crashing.org with a 
Signed-off-by.

-Scott

      reply	other threads:[~2008-09-30 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-26 23:00 FCC1 failing on large packet PINGS, while FCC2 is successful embedded
2008-09-29 14:43 ` Scott Wood
2008-09-30 16:46   ` embedded
2008-09-30 16:49     ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E2589D.8090406@freescale.com \
    --to=scottwood@freescale.com \
    --cc=embedded@akb.net \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).