From: Felix Radensky <felix@embedded-sol.com>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: External interrupt on 460EX
Date: Thu, 16 Oct 2008 11:22:17 +0200 [thread overview]
Message-ID: <48F707C9.6040203@embedded-sol.com> (raw)
In-Reply-To: <200810160944.54428.sr@denx.de>
Hi, Stefan
Stefan Roese wrote:
> Felix,
>
> On Wednesday 15 October 2008, Felix Radensky wrote:
>
>>>> The interrupt is connected to GPIO 45. U-Boot (1.3.4) configures this
>>>> pin as external interrupt 12 (interrupt 20 in UIC 3). I've added the
>>>> following
>>>> entry to board device tree (in opb section)
>>>>
>>>> cpld@2,0 {
>>>> device_type = "cpld";
>>>> interrupts = <20 1>;
>>>>
>>> Is this interrupt active on rising edge? This is what you have configured
>>> here. When you need level, active low, then you need to write:
>>>
>>> interrupts = <20 8>;
>>>
>>> And be careful which dts version you are using. Is this 20 decimal or
>>> hex?
>>>
>> The interrupt is indeed level, active low. Where can I find information
>> on UIC
>> interrupt settings for device tree ?
>>
>
> Not sure if this is really documented. Those values are from
> include/asm-ppc/irq.h:
>
> #define IRQ_TYPE_NONE 0x00000000 /* Default, unspecified type
> */
> #define IRQ_TYPE_EDGE_RISING 0x00000001 /* Edge rising type */
> #define IRQ_TYPE_EDGE_FALLING 0x00000002 /* Edge falling type */
> #define IRQ_TYPE_EDGE_BOTH (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)
> #define IRQ_TYPE_LEVEL_HIGH 0x00000004 /* Level high type */
> #define IRQ_TYPE_LEVEL_LOW 0x00000008 /* Level low type */
>
>
Thanks for clarification. I was looking at booting-without-of.txt and
took my number
from there.
>> I'm using dtc 1.2.0, 20 is decimal.
>> Is it ok ?
>>
>
> This doesn't really depend on the dtc version but on the version of the dts
> file itself. Is your dts a v1 dts file? Do you have this in your dts:
>
> /dts-v1/;
>
> ?
>
> If yes, then you have a v1 dts file and all number without 0x are decimal
> numbers. Then the "20" is correct for ext IRQ 12. If not then this number is
> hex and you should write "14" instead.
>
>
Bingo !!! That was my problem. I've started getting interrupts after
changing the irq
number to 14.
Thanks a lot !!! Your answers are great as always.
Felix.
prev parent reply other threads:[~2008-10-16 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 14:43 External interrupt on 460EX Felix Radensky
2008-10-15 15:00 ` Stefan Roese
2008-10-15 15:18 ` Felix Radensky
2008-10-16 7:44 ` Stefan Roese
2008-10-16 9:22 ` Felix Radensky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F707C9.6040203@embedded-sol.com \
--to=felix@embedded-sol.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).