From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FADC34047 for ; Wed, 19 Feb 2020 12:56:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D29920801 for ; Wed, 19 Feb 2020 12:56:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D29920801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48MyR95MNTzDqZl for ; Wed, 19 Feb 2020 23:56:53 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48My3j3bdnzDqD1 for ; Wed, 19 Feb 2020 23:40:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 48My3h6S2Rz9sSd; Wed, 19 Feb 2020 23:40:00 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 477f3488a94e35380c82a7498d46f10fa5f3edd2 In-Reply-To: <7bce32ccbab3ba3e3e0f27da6961bf6313df97ed.1581663140.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Larry Finger From: Michael Ellerman Subject: Re: [PATCH] powerpc/6xx: Fix power_save_ppc32_restore() with CONFIG_VMAP_STACK Message-Id: <48My3h6S2Rz9sSd@ozlabs.org> Date: Wed, 19 Feb 2020 23:40:00 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 2020-02-14 at 06:53:00 UTC, Christophe Leroy wrote: > power_save_ppc32_restore() is called during exception entry, before > re-enabling the MMU. It substracts KERNELBASE from the address > of nap_save_msscr0 to access it. > > With CONFIG_VMAP_STACK enabled, data MMU translation has already been > re-enabled, so power_save_ppc32_restore() has to access > nap_save_msscr0 by its virtual address. > > Reported-by: Larry Finger > Signed-off-by: Christophe Leroy > Fixes: cd08f109e262 ("powerpc/32s: Enable CONFIG_VMAP_STACK") > Tested-by: Larry Finger Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/477f3488a94e35380c82a7498d46f10fa5f3edd2 cheers