From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D117C83038 for ; Tue, 1 Jul 2025 19:32:12 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4bWtT64FYKz30FR; Wed, 2 Jul 2025 05:32:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1751398330; cv=none; b=DLjiEOVPTuZJDgIhP3yvFWl4WSo2U3bbRXHEB77ixnXahzi8azcvW2hDe9PAaY0PYyWdDbuRA6PQUKr/n1TU5qQx+aoQu1ilal9VCd8JPw8iyYOmvH9gcqS00omt0jQ0/UoZJzfeqhqucK+1OU2EEt49sSA1MfmJNMQUSUcpkqq8434BkrMIfCuYBADiexoOwnPQnoEi19ZmsKfzSKO6bXKVWoACfMwtnjN7JXe5HIMMrqAep4i1+r1C42r6Mi7Bx0pj4SjO451ooBYRMzDhUVXXdB7c51mtGGYzW4TWfuSbt1TZK4iC8kDOuI9yv24Z5MlevVr0r5oVX16S1vOJlA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1751398330; c=relaxed/relaxed; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P7Sdz3kxk133jko7I4xmgw6meGAh/glaB1sbzACzkx83+waWppRcp4pwJYIBqyGJZ7gUBclLI42q8RqQwj0bZryGmVMDRh8l3FUxc98e0XEzVhbddAp4J4k6WK0CwNr32KcesFyOc05RSyvSI5OJk3zpviOIM2Vt+wDFp9tNdIphN9wo3COSE16IFVQbyz6co7BMmUehOjoHPEV4css6geh2+104eI0N2LL/H9ZooKdWLwCqiD60U8AjCM0MZiNLpnjArNmqbfu9XtCwwEfR9WKVH50p6hDygbrUrQtdS0HPF+wsnkomjjwp2Z5kuZBg9aE6PO2Kd3134pEJGWavhw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K0Hs+WKx; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K0Hs+WKx; dkim-atps=neutral; spf=pass (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) smtp.mailfrom=redhat.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K0Hs+WKx; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=K0Hs+WKx; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4bWtT45lclz2xdg for ; Wed, 2 Jul 2025 05:32:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751398323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; b=K0Hs+WKxKgxT7Hhfk6Xy57k/UoW+84fT0uJ/Q5gbrpT/gUDMGJ/fLvZpKdNMIdV9TDBQSU aNWOd1GdRL70/cZ1zwJPzKS3hcRQIH1bPXMGY15Hj0eFTBgrDLRzfvhAmIGKh6SJ3bDhrz KXrOGQTlWt7zjG/TCr+aafFc8qOnUYM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751398323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; b=K0Hs+WKxKgxT7Hhfk6Xy57k/UoW+84fT0uJ/Q5gbrpT/gUDMGJ/fLvZpKdNMIdV9TDBQSU aNWOd1GdRL70/cZ1zwJPzKS3hcRQIH1bPXMGY15Hj0eFTBgrDLRzfvhAmIGKh6SJ3bDhrz KXrOGQTlWt7zjG/TCr+aafFc8qOnUYM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-74xgoGnuN8S8sl0uoHN2Pw-1; Tue, 01 Jul 2025 15:32:01 -0400 X-MC-Unique: 74xgoGnuN8S8sl0uoHN2Pw-1 X-Mimecast-MFC-AGG-ID: 74xgoGnuN8S8sl0uoHN2Pw_1751398320 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso32643175e9.0 for ; Tue, 01 Jul 2025 12:32:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751398320; x=1752003120; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pan++p2TzQShdGmkALz5U+1UZhqUiE8i0SNRToHfyJg=; b=C6QSZxWfVXIky/O+JdjthmdsVITv4Av/6e6bWukROvBKG7T7oPiNOVVmgmn55hsCY/ 3QyPcDOLuU6Z5yIFYYM4dg2+skuM3hIqtk7nTKImnQjUiDl3eAVdhTcHAo3XClixkVih X7W7jw4Ozn2/UuY1KAq+c1KCnoAUghidLvKr+81h04qL/Yf68cKCoLxOvjHCPtBrKbf+ mCJAtwdzlIVPSR7t8dZQAs0hDuhrdq0VqlMFyoXqRfjHs7F6egtoWlsS+FTDu7cS4NrG AOr11kWLEVP4q0OsaGU1vCQKMRx8axY16QsLUB+DBTL5Mc64MK0IEq0oXoPTaQdrAsFP 9PrA== X-Forwarded-Encrypted: i=1; AJvYcCXS0pVQpEVbz7FffW/O9mwOl4FYVQKanzGcPBbYKFVk8KI3sw+3VYewBuqye45U2z9aunrh49v+3dWqQH8=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yy1cH0htUYdTTKETGNaWSIZlUSMKYXisYPtSxqlGm6X2GDxHILF tdQ1bn/g4c4dQkXXQ8MZEvXBiw7e+693r+ySCa+7mgvHmBPIuFducPZH6YqMopKjMrHlvLWpfVJ VnYvB1Bxz5oTjJPvmviax0a9wFaDOmeqxqeHxJWwiVGiV0pCKOCqozwe8AKi4Q4431yc= X-Gm-Gg: ASbGnct0ggGBtcFnRwY9Rj9VQXE3ccP956Mn78O0cXrdfZsqhSSNvXMolOa6u2ln0PT zhid54SFYijja3IyW0tKp3f4Qg0DuRkgWIS36HI/63mffFdrXhupKgyqRdTw2Z8HjB1yOtkYhDX 5Ajsuwvdy6V0WLS9P+gkm4nucAB6bIUEQhwxHdtrk0aeobOPha8TOhVImXtOEb36zDjyRck9t// 3Z8qy8ZjKPDuvvae0sqxzj/PYrkHQ1kbRTEzEW68fWDh7/2TIZdSRB7z9LnPP9SoE07Nz3SyfnA vk0mfcWUvsGeT8IwpavbLJgYU0h7kuUdzV9++xZY3fu7OdjNLlZR+OvKCtWnUeIjClsmB50LUk1 ExiQjlCGIXuRktHWZSzt331TxnXjD+V3WEr8Zj97K4yRf2eJMlg== X-Received: by 2002:a05:600c:8211:b0:43b:c857:e9d7 with SMTP id 5b1f17b1804b1-454a36e495amr3357105e9.5.1751398320063; Tue, 01 Jul 2025 12:32:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5TyN7r+4oBk64JocA+5QoglGL345dK2Fcu0b1IazgnSHOIgn7V2SOlRTU0EkUwtcUGQo9tg== X-Received: by 2002:a05:600c:8211:b0:43b:c857:e9d7 with SMTP id 5b1f17b1804b1-454a36e495amr3356625e9.5.1751398319493; Tue, 01 Jul 2025 12:31:59 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823ad01csm206159325e9.22.2025.07.01.12.31.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 12:31:59 -0700 (PDT) Message-ID: <48e9a5de-3131-4e36-8a21-5f77669116a9@redhat.com> Date: Tue, 1 Jul 2025 21:31:56 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 22/29] mm/page-flags: rename PAGE_MAPPING_MOVABLE to PAGE_MAPPING_ANON_KSM To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-23-david@redhat.com> <5357d4d9-d817-4351-9927-bcd03794964c@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5357d4d9-d817-4351-9927-bcd03794964c@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xKKbgKcjFZg0AojWtTmxhTjmdzatDUwFD4ytqWAdCJI_1751398320 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.07.25 14:54, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 03:00:03PM +0200, David Hildenbrand wrote: >> KSM is the only remaining user, let's rename the flag. While at it, >> adjust to remaining page -> folio in the doc. > > Hm I wonder if we could just ideally have this be a separate flag rather than a > bitwise combination, however I bet there's code that does somehow rely on this. Well, KSM folios are anon folios, so that must hold. Of course, now you could make folio_test_anon() test both bits, and have KSM folios only set a PAGE_MAPPING_KSM bit. That should be possible on top of this change, but not sure if that's really what we want. After all, KSM folios are special ANON folios. > > I know for sure there's code that has to do a folio_test_ksm() on something > folio_test_anon()'d because the latter isn't sufficient. > > But this is one for the future I guess :) Yes :) > > Nice: re change to folio, that is a nice cleanup based on fact you've now made > the per-page mapping op stuff not be part of this. > >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > LGTM, so: > > Reviewed-by: Lorenzo Stoakes Thanks! -- Cheers, David / dhildenb