From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58D64D26D6F for ; Fri, 9 Jan 2026 17:22:06 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dnpVN6j6Fz2xm5; Sat, 10 Jan 2026 04:22:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1767979324; cv=none; b=IDk/eGMhS5LmQwgoYJN8Cy6xpt9bK05asqHKzR4Mfh4qqi6eMkaECbNGC2nDxGpPFgZFSpaIXmjWDGoHuYSmxvzFvUm4BvFz9Vdh/pRF61J/gtzMPTxeIRauaGY7mxqipPtb96uUIEdf0yzoV3vfMJvG7+jEU32t8S0C9uNqy7WF002YT4g5pVWGI9De7J31PA/9It7aLGQxUeTDkFVj0rdqiMEw+W3X4cSFnyPq9hv3kTeqLlfeN5YgpScvOlFQq4psREkEOs7bwLVz4LzPc1WyMoQCefb3YJi8BQppG4LWFyXbGkcim7Do37BOatSsCUNb1c35yrusu5Zx23qebQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1767979324; c=relaxed/relaxed; bh=LrvaMEFksRwNf+9QjYnHfEu8TPiJ1u3+Dlfy3rKK+wE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dK+0b3FSEhzS0G1kdbFASJdfkJva8/RJ0PTozY0PzhuTjA1y+fAquVvqHXQ13cu5F7Pe5kb8w+vLR4R1qQi2paT8eZDLNzq2WkSKVzMTxJAC3bQe5kpigHz6HlfrbkFPfQ3ZZgyMgCOJp9pUJFQ4Ml9pbRuVeU3X2IvV0BUMg4Y7HOzA5ExNVBiThfFqFH/OyCF3sLfbubgWk3F/5+NQLqn8NtyNw5XeLY8le2sjcIQQ877IafP9ugwg3wFht1/XOfVPhTbdTfMmy2C7fh5KzjYLy+lpUHhyAZI4rzQgVxPZ7Jo3sHvTbU+3y4dNXqI/fhHNIGGT8Ekv/YvpfrksTA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fMWxy9I1; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fMWxy9I1; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dnpVN15JKz2xHP for ; Sat, 10 Jan 2026 04:22:04 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8A89560178; Fri, 9 Jan 2026 17:22:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2F1AC4CEF1; Fri, 9 Jan 2026 17:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767979321; bh=G0CdK1BbKzMKU+qqbitcHl4o9Pf/LHQ1vf98qGeQbYE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fMWxy9I1T3LHdLmPtdMUL88DS3wYXB71qViQVOCn0+8QCbajTFBrfCs8mqRUXy+Y4 4E+eBYsitwzT/qE/4+xLri8dA5feTyUtep33ImpFVLB2+Wxssd+JDlhKBMSAEgTwgb jnchWeKlErbxlJm9dPOlSzhoP46/HA2MEdAQR6j1cvUjT1Z48s7+DCjf3C8gGAwNSr BUXYSgbI6w2J7+HijlF38X8OoLlcZ7PktPyZMuYV6gFQjkfwBvlk7LRC/7Nd22e6Z+ gB/+xmfzZzhw6BchvPsR2Qael3H05SiSbrl7pdb++/DLGljx6tybl/LamhByeVke5T r+n5loRskMeeA== Message-ID: <48faa7b1-d486-406a-a8c4-a1c9609e7fc6@kernel.org> Date: Fri, 9 Jan 2026 18:21:47 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/12] powerpc/fsp2: Simplify with scoped for each OF child loop To: Krzysztof Kozlowski , Miguel Ojeda , Rob Herring , Saravana Kannan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Russell King , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Krzysztof Kozlowski , Alim Akhtar , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Nipun Gupta , Nikhil Agarwal , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vinod Koul , Sylwester Nawrocki , Mauro Carvalho Chehab , "Rafael J. Wysocki" , Viresh Kumar Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-clk@vger.kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org, Jonathan Cameron References: <20260109-of-for-each-compatible-scoped-v3-0-c22fa2c0749a@oss.qualcomm.com> <20260109-of-for-each-compatible-scoped-v3-4-c22fa2c0749a@oss.qualcomm.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260109-of-for-each-compatible-scoped-v3-4-c22fa2c0749a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 09/01/2026 à 17:57, Krzysztof Kozlowski a écrit : > Use scoped for-each loop when iterating over device nodes to make code a > bit simpler. > > Reviewed-by: Jonathan Cameron > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Christophe Leroy (CS GROUP) > --- > > Depends on the first patch. > --- > arch/powerpc/platforms/44x/fsp2.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c > index f6b8d02e08b0..b06d9220844c 100644 > --- a/arch/powerpc/platforms/44x/fsp2.c > +++ b/arch/powerpc/platforms/44x/fsp2.c > @@ -199,16 +199,14 @@ static irqreturn_t rst_wrn_handler(int irq, void *data) { > > static void __init node_irq_request(const char *compat, irq_handler_t errirq_handler) > { > - struct device_node *np; > unsigned int irq; > int32_t rc; > > - for_each_compatible_node(np, NULL, compat) { > + for_each_compatible_node_scoped(np, NULL, compat) { > irq = irq_of_parse_and_map(np, 0); > if (!irq) { > pr_err("device tree node %pOFn is missing a interrupt", > np); > - of_node_put(np); > return; > } > > @@ -216,7 +214,6 @@ static void __init node_irq_request(const char *compat, irq_handler_t errirq_han > if (rc) { > pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d", > np, rc); > - of_node_put(np); > return; > } > } >