From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C7FC10F29 for ; Tue, 17 Mar 2020 13:37:13 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E4B22076C for ; Tue, 17 Mar 2020 13:37:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E4B22076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48hZ3C3HYXzDqRJ for ; Wed, 18 Mar 2020 00:37:11 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48hYYL3XgwzDqfB for ; Wed, 18 Mar 2020 00:14:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 48hYYH662sz9sSM; Wed, 18 Mar 2020 00:14:43 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: ffd3eaf178b0f616a071e510e289d937330b0b35 In-Reply-To: <20200224211848.26087-1-joe.lawrence@redhat.com> To: Joe Lawrence , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [PATCH] powerpc/vdso: remove deprecated VDS64_HAS_DESCRIPTORS references Message-Id: <48hYYH662sz9sSM@ozlabs.org> Date: Wed, 18 Mar 2020 00:14:43 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 2020-02-24 at 21:18:48 UTC, Joe Lawrence wrote: > The original 2005 patch that introduced the powerpc vdso, pre-git > ("ppc64: Implement a vDSO and use it for signal trampoline") notes that: > > ... symbols exposed by the vDSO aren't "normal" function symbols, apps > can't be expected to link against them directly, the vDSO's are both > seen as if they were linked at 0 and the symbols just contain offsets > to the various functions. This is done on purpose to avoid a > relocation step (ppc64 functions normally have descriptors with abs > addresses in them). When glibc uses those functions, it's expected to > use it's own trampolines that know how to reach them. > > Despite that explanation, there remains dead #ifdef > VDS64_HAS_DESCRIPTORS code-blocks that provide alternate function > definitions that setup function descriptors. > > Since VDS64_HAS_DESCRIPTORS has been unused for all these years, we > might as well finally remove it from the codebase. > > Link: https://lists.ozlabs.org/pipermail/linuxppc-dev/2020-February/204430.= > html > Link: https://lore.kernel.org/lkml/1108002773.7733.196.camel@gaston/ > Signed-off-by: Joe Lawrence Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/ffd3eaf178b0f616a071e510e289d937330b0b35 cheers