From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Fangrui Song <maskray@google.com>, linuxppc-dev@lists.ozlabs.org
Cc: clang-built-linux@googlegroups.com,
Nick Desaulniers <ndesaulniers@google.com>,
Joel Stanley <joel@jms.id.au>, Fangrui Song <maskray@google.com>,
Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH v2] powerpc/boot: Delete unneeded .globl _zimage_start
Date: Wed, 1 Apr 2020 23:53:31 +1100 (AEDT) [thread overview]
Message-ID: <48smMv6Sqjz9sTF@ozlabs.org> (raw)
In-Reply-To: <20200325164257.170229-1-maskray@google.com>
On Wed, 2020-03-25 at 16:42:57 UTC, Fangrui Song wrote:
> .globl sets the symbol binding to STB_GLOBAL while .weak sets the
> binding to STB_WEAK. GNU as let .weak override .globl since binutils-gdb
> 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang integrated
> assembler let the last win but it may error in the future.
>
> Since it is a convention that only one binding directive is used, just
> delete .globl.
>
> Fixes: cd197ffcf10b "[POWERPC] zImage: Cleanup and improve zImage entry point"
> Fixes: ee9d21b3b358 "powerpc/boot: Ensure _zimage_start is a weak symbol"
> Link: https://github.com/ClangBuiltLinux/linux/issues/937
> Signed-off-by: Fangrui Song <maskray@google.com>
> Cc: Alan Modra <amodra@gmail.com>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Segher Boessenkool <segher@kernel.crashing.org>
> Cc: clang-built-linux@googlegroups.com
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/968339fad422a58312f67718691b717dac45c399
cheers
prev parent reply other threads:[~2020-04-01 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 16:42 [PATCH v2] powerpc/boot: Delete unneeded .globl _zimage_start Fangrui Song
2020-03-26 22:16 ` Segher Boessenkool
2020-03-26 22:26 ` Fangrui Song
2020-03-27 15:24 ` Segher Boessenkool
2020-03-27 16:50 ` Fangrui Song
2020-03-27 18:27 ` Segher Boessenkool
2020-04-01 12:53 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48smMv6Sqjz9sTF@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=amodra@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maskray@google.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).