* [PATCH v2] powerpc: Add missing irq free in fs_enet error path.
@ 2008-10-25 1:03 Mike Ditto
2008-10-27 13:45 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Mike Ditto @ 2008-10-25 1:03 UTC (permalink / raw)
To: linuxppc-dev
If something goes wrong attaching to phy driver, we weren't freeing the IRQ.
Signed-off-by: Mike Ditto <mditto@consentry.com>
---
I just noticed this file has already been touched in -rc1 so here is the
patch again, adjusted accordingly.
diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/drivers/net/fs_enet/fs_enet-main.c
--- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c 2008-10-24 17:54:31.000000000 -0700
+++ NEW/drivers/net/fs_enet/fs_enet-main.c 2008-10-24 17:57:03.000000000 -0700
@@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic
err = fs_init_phy(dev);
if (err) {
+ free_irq(fep->interrupt, dev);
if (fep->fpi->use_napi)
napi_disable(&fep->napi);
return err;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] powerpc: Add missing irq free in fs_enet error path.
2008-10-25 1:03 [PATCH v2] powerpc: Add missing irq free in fs_enet error path Mike Ditto
@ 2008-10-27 13:45 ` Kumar Gala
2008-10-27 21:46 ` [PATCH v2] powerpc/fs_enet: Add missing irq free in " Mike Ditto
0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2008-10-27 13:45 UTC (permalink / raw)
To: Mike Ditto; +Cc: linuxppc-dev
On Oct 24, 2008, at 8:03 PM, Mike Ditto wrote:
> If something goes wrong attaching to phy driver, we weren't freeing
> the IRQ.
>
> Signed-off-by: Mike Ditto <mditto@consentry.com>
> ---
> I just noticed this file has already been touched in -rc1 so here is
> the
> patch again, adjusted accordingly.
>
> diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/
> drivers/net/fs_enet/fs_enet-main.c
> --- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c 2008-10-24
> 17:54:31.000000000 -0700
> +++ NEW/drivers/net/fs_enet/fs_enet-main.c 2008-10-24
> 17:57:03.000000000 -0700
> @@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic
>
> err = fs_init_phy(dev);
> if (err) {
> + free_irq(fep->interrupt, dev);
> if (fep->fpi->use_napi)
> napi_disable(&fep->napi);
> return err;
Please copy Jeff Garizk and the netdev list as such patches normally
go though that path.
- k
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] powerpc/fs_enet: Add missing irq free in error path.
2008-10-27 13:45 ` Kumar Gala
@ 2008-10-27 21:46 ` Mike Ditto
2009-01-13 16:28 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Mike Ditto @ 2008-10-27 21:46 UTC (permalink / raw)
To: netdev, linuxppc-dev
If something goes wrong attaching to phy driver, we weren't freeing
the IRQ.
Signed-off-by: Mike Ditto <mditto@consentry.com>
---
Reposting to CC netdev list. (Thanks, Kumar)
diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/drivers/net/fs_enet/fs_enet-main.c
--- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c 2008-10-24 17:54:31.000000000 -0700
+++ NEW/drivers/net/fs_enet/fs_enet-main.c 2008-10-24 17:57:03.000000000 -0700
@@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic
err = fs_init_phy(dev);
if (err) {
+ free_irq(fep->interrupt, dev);
if (fep->fpi->use_napi)
napi_disable(&fep->napi);
return err;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] powerpc/fs_enet: Add missing irq free in error path.
2008-10-27 21:46 ` [PATCH v2] powerpc/fs_enet: Add missing irq free in " Mike Ditto
@ 2009-01-13 16:28 ` Kumar Gala
2009-01-15 4:44 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2009-01-13 16:28 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Mike Ditto, linuxppc-dev list
On Oct 27, 2008, at 4:46 PM, Mike Ditto wrote:
> If something goes wrong attaching to phy driver, we weren't freeing
> the IRQ.
>
> Signed-off-by: Mike Ditto <mditto@consentry.com>
> ---
> Reposting to CC netdev list. (Thanks, Kumar)
>
> diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/
> drivers/net/fs_enet/fs_enet-main.c
> --- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c 2008-10-24
> 17:54:31.000000000 -0700
> +++ NEW/drivers/net/fs_enet/fs_enet-main.c 2008-10-24
> 17:57:03.000000000 -0700
> @@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic
>
> err = fs_init_phy(dev);
> if (err) {
> + free_irq(fep->interrupt, dev);
> if (fep->fpi->use_napi)
> napi_disable(&fep->napi);
> return err;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
Dave,
This seems to have gotten lost in the shuffle. Can you please apply.
- k
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] powerpc/fs_enet: Add missing irq free in error path.
2009-01-13 16:28 ` Kumar Gala
@ 2009-01-15 4:44 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2009-01-15 4:44 UTC (permalink / raw)
To: galak; +Cc: netdev, mditto, linuxppc-dev
From: Kumar Gala <galak@kernel.crashing.org>
Date: Tue, 13 Jan 2009 10:28:15 -0600
>
> On Oct 27, 2008, at 4:46 PM, Mike Ditto wrote:
>
> > If something goes wrong attaching to phy driver, we weren't freeing
> > the IRQ.
> >
> > Signed-off-by: Mike Ditto <mditto@consentry.com>
...
> This seems to have gotten lost in the shuffle. Can you please apply.
The netdev patchwork never saw it for some reason.
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-15 4:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-25 1:03 [PATCH v2] powerpc: Add missing irq free in fs_enet error path Mike Ditto
2008-10-27 13:45 ` Kumar Gala
2008-10-27 21:46 ` [PATCH v2] powerpc/fs_enet: Add missing irq free in " Mike Ditto
2009-01-13 16:28 ` Kumar Gala
2009-01-15 4:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).