From: Timur Tabi <timur@freescale.com>
To: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH V2] powerpc: Fix Book-E watchdog timer interval setting
Date: Mon, 03 Nov 2008 10:28:55 -0600 [thread overview]
Message-ID: <490F26C7.1000109@freescale.com> (raw)
In-Reply-To: <200811030956.37948.matthias.fuchs@esd-electronics.com>
Matthias Fuchs wrote:
> Timur,
>
> I missed you posting. But you are right. My patch is ok for 4xx CPUs and touching
> the CONFIG_FSL_BOOKE path was not my intention.
>
> So for CONFIG_FSL_BOOKE WDTP_MASK should be WDTP(0). There is still a slightly difference
> between WDTP(0)="(3 << 30) | (0x3c << 15)" and "(3 << 30) | (15 << 15)".
> Can you check that please and I will resend my patch.
Yes, I think WDTP(0) is correct for Book E.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2008-11-03 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 12:48 [PATCH] powerpc: Fix Book-E watchdog timer interval setting Matthias Fuchs
2008-08-07 13:19 ` Kumar Gala
2008-08-07 14:04 ` Matthias Fuchs
2008-09-19 21:28 ` Matthias Fuchs
2008-09-19 21:44 ` Kumar Gala
2008-09-23 15:04 ` [PATCH V2] " Matthias Fuchs
2008-09-23 16:31 ` Timur Tabi
2008-11-03 8:56 ` Matthias Fuchs
2008-11-03 16:28 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490F26C7.1000109@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthias.fuchs@esd-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).