From: Steven Rostedt <srostedt@redhat.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
linuxppc-dev@ozlabs.org, Linus Torvalds <torvalds@osdl.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH][for 2.6.28] Remove -mno-spe flags as they dont belong
Date: Mon, 17 Nov 2008 15:52:03 -0500 [thread overview]
Message-ID: <4921D973.7010208@redhat.com> (raw)
In-Reply-To: <1226772154-6109-1-git-send-email-galak@kernel.crashing.org>
Kumar Gala wrote:
> For some unknown reason at Steven Rostedt added in disabling of the SPE
> instruction generation for e500 based PPC cores in commit
> 6ec562328fda585be2d7f472cfac99d3b44d362a.
>
> We are removing it because:
>
> 1. It generates e500 kernels that don't work
> 2. its not the correct set of flags to do this
> 3. we handle this in the arch/powerpc/Makefile already
> 4. its unknown in talking to Steven why he did this
>
>
I just tested this change on both my PPC64 and my 32bit Powerbook.
Tested-and-Acked-by: Steven Rostedt <srostedt@redhat.com>
-- Steve
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> kernel/Makefile | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 9a3ec66..19fad00 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -11,8 +11,6 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
> hrtimer.o rwsem.o nsproxy.o srcu.o semaphore.o \
> notifier.o ksysfs.o pm_qos_params.o sched_clock.o
>
> -CFLAGS_REMOVE_sched.o = -mno-spe
> -
> ifdef CONFIG_FUNCTION_TRACER
> # Do not trace debug files and internal ftrace files
> CFLAGS_REMOVE_lockdep.o = -pg
> @@ -21,7 +19,7 @@ CFLAGS_REMOVE_mutex-debug.o = -pg
> CFLAGS_REMOVE_rtmutex-debug.o = -pg
> CFLAGS_REMOVE_cgroup-debug.o = -pg
> CFLAGS_REMOVE_sched_clock.o = -pg
> -CFLAGS_REMOVE_sched.o = -mno-spe -pg
> +CFLAGS_REMOVE_sched.o = -pg
> endif
>
> obj-$(CONFIG_FREEZER) += freezer.o
>
prev parent reply other threads:[~2008-11-17 20:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 18:02 [PATCH][for 2.6.28] Remove -mno-spe flags as they dont belong Kumar Gala
2008-11-15 18:10 ` Steven Rostedt
2008-11-17 14:31 ` Kumar Gala
2008-11-17 14:33 ` Kumar Gala
2008-11-17 20:52 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4921D973.7010208@redhat.com \
--to=srostedt@redhat.com \
--cc=akpm@osdl.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).