linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Steven A. Falco" <sfalco@harris.com>
To: "Steven A. Falco" <sfalco@harris.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH v5] spi: Add PPC4xx SPI driver
Date: Tue, 09 Dec 2008 17:14:12 -0500	[thread overview]
Message-ID: <493EEDB4.8070003@harris.com> (raw)
In-Reply-To: <493EE79C.9000405@harris.com>

Steven A. Falco wrote:
> Stefan Roese wrote:
>> This adds a SPI driver for the SPI controller found in the IBM/AMCC
>> 4xx PowerPC's.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
>> Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>> ---
>
> How is this intended to work?  An example .dts would be greatly
> appreciated.

Answered my own question.  The gpios must be directly under the spi
node rather than elsewhere in the tree.  This works:

			SPI0: spi@ef600900 {
				compatible = "ibm,ppc4xx-spi";
				reg = <ef600900 7>;
				interrupts = <8 4>;
				interrupt-parent = <&UIC0>;

				gpios = <&GPIO1 14 0>;
			};

  reply	other threads:[~2008-12-09 22:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 15:48 [PATCH v5] spi: Add PPC4xx SPI driver Stefan Roese
2008-12-09 21:48 ` Steven A. Falco
2008-12-09 22:14   ` Steven A. Falco [this message]
2008-12-27 19:30 ` David Brownell
2009-01-05 18:12   ` Stefan Roese
2009-01-05 19:31     ` Wolfgang Denk
2009-01-06  8:26       ` Stefan Roese
2008-12-27 19:32 ` David Brownell
2008-12-27 21:36   ` Stephen Rothwell
2009-01-06  2:06 ` [spi-devel-general] " Anton Vorontsov
2009-01-06  8:14   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493EEDB4.8070003@harris.com \
    --to=sfalco@harris.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).